Skip to content

fix(ci): use an allowlisted docker/login-action pin - #630

Merged
nic-6443 merged 1 commit into
apache:masterfrom
nic-6443:ci/bump-login-action-allowlisted-sha
Aug 6, 2026
Merged

fix(ci): use an allowlisted docker/login-action pin#630
nic-6443 merged 1 commit into
apache:masterfrom
nic-6443:ci/bump-login-action-allowlisted-sha

Conversation

@nic-6443

@nic-6443 nic-6443 commented Aug 5, 2026

Copy link
Copy Markdown
Member

Why submit this pull request?

  • Bugfix

What changes will this PR take into?

The Docker image workflow has been dead since 2026-07-11 — every run ends in startup_failure before a single job is created, so it never even shows up as a failing check. docker/login-action@b45d80f8 (v4.0.0) was dropped from the ASF approved actions list, and the run annotation says:

The action docker/login-action@b45d80f is not allowed in apache/apisix-docker because all actions must be from a repository owned by your enterprise, created by GitHub, or match one of the patterns: ...

approved_patterns.yml now only lists v4.1.0 through v4.6.0 for login-action, so this bumps the pin to v4.6.0 (dbcb813823bdd20940b903addbd779551569679f). The setup-qemu-action and setup-buildx-action pins are still on the list and are left alone.

Runs affected so far: the release/apisix-3.17.0 push for #627, and both the PR run and the master push for #629. Because the release branch build never started, apache/apisix:3.17.0-* and latest on Docker Hub are still the 2026-06-18 build and do not contain the libxml2/libxslt fix from #627 — the images need a rebuild once this lands.

Same class of breakage as #619, just a different action that aged out of the allowlist.

Related issues

N/A

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

docker/login-action@b45d80f8 (v4.0.0) was dropped from the ASF approved
actions list, so every run of the Docker image workflow since 2026-07-11
ends in startup_failure before any job is created:

  The action docker/login-action@b45d80f
  is not allowed in apache/apisix-docker because all actions must be from
  a repository owned by your enterprise, created by GitHub, or match one
  of the patterns: ...

Bump to v4.6.0, the newest pin currently present in
apache/infrastructure-actions/approved_patterns.yml.
@nic-6443
nic-6443 merged commit b614479 into apache:master Aug 6, 2026
12 of 15 checks passed
@nic-6443
nic-6443 deleted the ci/bump-login-action-allowlisted-sha branch August 6, 2026 02:15
nic-6443 added a commit that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants