Make command replies consistent with requests - #24
Conversation
|
Hello @macvenez, checking your PR I think we could go the Redis protocol route. What about: Starting the reply with "+" in case of successful reply. "-" in case of errors? |
|
Yes! That's an even better idea, I'll edit it accordingly. Can you illustrate what's going to happen with .join? That's an example code: Shouldn't the output be: |
|
Great. Thanks. The problem with join is only here AFAIK: >>> "$, ".join(["a","b","c"])
'a$, b$, c' |
|
Alright, now I see it, that should be easily fixable with: of course that |
resolves #22
I added $ character to each command reply.
It might be unnecessary in some conditions like replies to commands with wrong number of arguments.
In general I think it's good anyway to easily distiguish between messages