fix: honor aws_profile when inferring Bedrock region - #1758
Open
nightcityblade wants to merge 2 commits into
Open
fix: honor aws_profile when inferring Bedrock region#1758nightcityblade wants to merge 2 commits into
nightcityblade wants to merge 2 commits into
Conversation
Author
|
Updated the branch with current upstream main and resolved the test-file conflict while preserving both the new upstream Bedrock coverage and this PR's constructor-profile regression test. Targeted verification passes: 3 tests passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #892
Thread the constructor
aws_profilethrough_infer_region()so Bedrock region inference consults the same profile the client will actually use instead of always probing the default profile.Local verification:
PYTHONPATH=/tmp/anthropic-sdk-python/src python3.9 -m pytest tests/lib/test_bedrock.py -k "region_infer_from_specified_profile or region_infer_from_constructor_profile" -q -o addopts=