started #287 by deleting some unnecessary comments and removing unuse… - #289
Open
VogtIndustries wants to merge 1 commit into
Open
started #287 by deleting some unnecessary comments and removing unuse…#289VogtIndustries wants to merge 1 commit into
VogtIndustries wants to merge 1 commit into
Conversation
…d assets. Hopefully fixed android wrapping problem Signed-off-by: Marcel Vogt <marcel.vogt@campus.tu-berlin.de>
There was a problem hiding this comment.
Pull request overview
This PR adjusts the home screen quick-actions layout to avoid Android flex-wrapping issues and performs a small auth-area cleanup by removing inline rationale comments.
Changes:
- Updated
QuickActionsGrid/QuickActionCardflex sizing to prevent unintended wrapping and enforce a single-row layout. - Removed several explanatory comments in auth screens and the auth stack layout.
Reviewed changes
Copilot reviewed 5 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/ailixir/src/components/organisms/quick-actions-grid.tsx | Forces a single-row quick-actions layout (nowrap) and stretches container to full width. |
| frontend/ailixir/src/components/molecules/quick-action-card.tsx | Makes cards flex to share row width; adjusts Pressable sizing to match Link variant behavior. |
| frontend/ailixir/src/app/(auth)/signup.tsx | Removes inline rationale comments around email normalization and navigation behavior. |
| frontend/ailixir/src/app/(auth)/login.tsx | Removes inline rationale comments around navigation/auth error handling. |
| frontend/ailixir/src/app/(auth)/_layout.tsx | Removes a block comment about not having a “success” screen. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
17
to
19
| await signUpAsync({ | ||
| email: data.email.trim().toLowerCase(), | ||
| password: data.password, |
| // `replace` (not `push`) so the back button doesn't return the user | ||
| // to a half-filled signup form. Stale form state in the back stack | ||
| // is a known UX pitfall. | ||
| router.replace('./login'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d assets. Hopefully fixed android wrapping problem