Skip to content

Fix empty collection checks in interpolation methods. Realy an edge c… #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
novitk wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix empty collection checks in interpolation methods. Realy an edge c… #323

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
61d376d
Fix empty collection checks in interpolation methods. Realy an edge c…
Jul 8, 2026
1f29259
Potential fix for pull request finding
novitk Jul 8, 2026
ccd323e
Fix MixedInterpolation range handling and validation
Jul 9, 2026
4ccda7b
Merge branch 'frontier' of github.com:novitk/QLNet into frontier
Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions src/QLNet/Math/Interpolations/MixedInterpolation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public MixedInterpolationImpl(List<double> xBegin, int xEnd,
xBegin2_ = xBegin.GetRange(n_, xBegin.Count - n_);
yBegin2_ = yBegin.GetRange(n_, yBegin.Count - n_);

Utils.QL_REQUIRE(xBegin2_.Count < size_, () => "too large n (" + n + ") for " + size_ + "-element x sequence");
Utils.QL_REQUIRE(xBegin2_.Count < xBegin.Count, () => "too large n (" + n + ") for " + size_ + "-element x sequence");

Comment on lines 56 to 60
switch (behavior)
{
Expand All @@ -65,8 +65,16 @@ public MixedInterpolationImpl(List<double> xBegin, int xEnd,
interpolation2_ = factory2.interpolate(xBegin_, size_, yBegin_);
break;
case Behavior.SplitRanges:
interpolation1_ = factory1.interpolate(xBegin_, n_, yBegin_);
interpolation2_ = factory2.interpolate(xBegin2_, size_ - n, yBegin2_);
if (size_ <= n_)
{
interpolation1_ = factory1.interpolate(xBegin_, size_, yBegin_);
interpolation2_ = interpolation1_;
}
Comment on lines +68 to +72
Comment on lines +68 to +72
else
{
interpolation1_ = factory1.interpolate(xBegin_, n_, yBegin_);
interpolation2_ = factory2.interpolate(xBegin2_, size_- n_, yBegin2_);
}
break;
default:
Utils.QL_FAIL("unknown mixed-interpolation behavior: " + behavior);
Expand All @@ -83,14 +91,14 @@ public override void update()

public override double value(double x)
{
if (x<(xBegin2_.First()))
if (xBegin2_.Count == 0 || x < (xBegin2_.First()))
return interpolation1_.value(x, true);
return interpolation2_.value(x, true);
Comment on lines 92 to 96
}
Comment on lines 92 to 97

public override double primitive(double x)
{
if (x<(xBegin2_.First()))
if (xBegin2_.Count == 0 || x < (xBegin2_.First()))
return interpolation1_.primitive(x, true);
return interpolation2_.primitive(x, true) -
interpolation2_.primitive(xBegin2_.First(), true) +
Expand All @@ -99,14 +107,14 @@ public override double primitive(double x)

public override double derivative(double x)
{
if (x < (xBegin2_.First()))
if (xBegin2_.Count == 0 || x < (xBegin2_.First()))
return interpolation1_.derivative(x, true);
return interpolation2_.derivative(x, true);
}

public override double secondDerivative(double x)
{
if (x < (xBegin2_.First()))
if (xBegin2_.Count == 0 || x < (xBegin2_.First()))
return interpolation1_.secondDerivative(x, true);
return interpolation2_.secondDerivative(x, true);
}
Expand Down