feat(shared-shredding): Expose shared-shredding utilities#405
Open
dalingmeng wants to merge 5 commits into
Open
feat(shared-shredding): Expose shared-shredding utilities#405dalingmeng wants to merge 5 commits into
dalingmeng wants to merge 5 commits into
Conversation
dalingmeng
changed the title
dalingmeng
changed the title
lxy-9602
changed the title
dalingmeng
force-pushed
the
feature/shared-shredding-schema-utils
branch
4 times, most recently
from
dac41bc to
ae43061
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
zjw1111
reviewed
Jul 9, 2026
zjw1111
left a comment
zjw1111
left a comment
Collaborator
There was a problem hiding this comment.
Follow-ups on the newly exposed schema utils. See inline comments for the type-guard and test-gap items.
One doc fix on the PR description:
- The new public header path is
include/paimon/data/shredding/map_shared_shredding_schema_utils.h, notinclude/paimon/shredding/.... - "New public API" omits
LogicalToPhysicalSchema, which is also exposed publicly.
Please update the description to match.
Collaborator
|
The description uses |
dalingmeng
force-pushed
the
feature/shared-shredding-schema-utils
branch
from
ae43061 to
baaf4c1
Compare
lxy-9602
reviewed
Jul 10, 2026
lxy-9602
reviewed
Jul 10, 2026
dalingmeng
force-pushed
the
feature/shared-shredding-schema-utils
branch
3 times, most recently
from
34aa381 to
8d39220
Compare
dalingmeng
force-pushed
the
feature/shared-shredding-schema-utils
branch
from
8d39220 to
0f4cd63
Compare
zjw1111
reviewed
Jul 10, 2026
zjw1111
left a comment
zjw1111
left a comment
Collaborator
There was a problem hiding this comment.
A few non-blocking follow-ups on the new shared-shredding schema utilities. None block merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #342
Expose shared-shredding schema metadata utilities for downstream integrations.
This change introduces
MapSharedShreddingSchemaUtilsas a public schema-level utility for shared-shredding MAP layout. It provides:__field_mapping,__overflow, and__col_i.AttachMetadataToSchemato attach serialized shared-shredding metadata to Arrow fields.ExtractMetadataFromFieldto parse shared-shredding metadata from an Arrow field.The internal
MapSharedShreddingDefinecontinues to own metadata keys, while public callers can reuse the schema contract and metadata read/write helpers without depending on internalsrc/headers.Tests
MapSharedShreddingSchemaUtilsTest.*API and Format
This change affects public API in the
includedir.New public header:
include/paimon/data/shredding/map_shared_shredding_schema_utils.hNew public API:
MapSharedShreddingSchemaUtils::AttachMetadataToSchemaMapSharedShreddingSchemaUtils::ExtractMetadataFromFieldMapSharedShreddingSchemaUtils::LogicalToPhysicalSchemaThis change does not introduce a new storage format or protocol. It exposes existing shared-shredding schema/metadata conventions through public utilities.
Documentation
No.
Generative AI tooling
Generated-by: Qoder