feat(lumina): support Lumina tag filtering#404
Open
lxy-9602 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR upgrades the bundled Lumina dependency to v0.3.0 and adds Lumina tag-aware build/search support for Paimon C++ global vector indexes.
Main changes:
GlobalIndexer::GetExtraFieldNames()so index implementations can request extra table fields during global index construction.extra_field_idsthroughGlobalIndexIOMeta/GlobalIndexMeta, allowing Lumina tag fields to be recorded in index metadata.lumina.extension.build.tag.tag_schemais configured.VectorSearch.predicatefor Lumina tag filtering by converting Paimon predicates to LuminaTagFilter.=, range comparisons,IN, and compoundAND/OR.third_party/luminaheaders,liblumina.so, version metadata, and reference docs to Lumina v0.3.0.Tests
Added and updated tests covering:
NOT_IN, unknown tag fields, and literal type mismatches.int8,int16,int32,int64,float, anddouble.GetExtraFieldNames()behavior.API and Format
API:
GlobalIndexer::GetExtraFieldNames()returningResult<std::optional<std::vector<std::string>>>.GlobalIndexIOMetawith optionalextra_field_ids.Format:
GlobalIndexMeta.extra_field_idsis now populated for Lumina tag fields.Compatibility:
std::nullopt.Documentation
third_party/lumina/reference.Generative AI tooling
Generated-by: Codex (GPT-5)