Add real root classification - #150
Merged
Merged
Conversation
wegank
force-pushed
the
rrc-init
branch
5 times, most recently
from
August 9, 2026 11:20
4c546f7 to
8afd480
Compare
Collaborator
|
Many thanks for this. Shouldn't we export some key functions such as real_root_classification, multiplication_matrix, hermite_matrix ? |
Contributor
Author
|
That might be a good idea. GitHub is currently down, so I'll work on that later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a real root classification algorithm based on Hermite's quadratic forms. The algorithm is based on [Gaillard-Safey El Din 2024, Chapter 5] and my remark during JNCF 2026.