Skip to content

Fix issue when calling _core_groebner_basis_array from Oscar - #139

Merged
ederc merged 1 commit into
algebraic-solving:mainfrom
wegank:oscar-array-fix
Mar 27, 2026
Merged

Fix issue when calling _core_groebner_basis_array from Oscar#139
ederc merged 1 commit into
algebraic-solving:mainfrom
wegank:oscar-array-fix

Conversation

@wegank

@wegank wegank commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Closes #138.

@wegank
wegank marked this pull request as draft March 27, 2026 17:15
@wegank
wegank marked this pull request as ready for review March 27, 2026 17:25
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.50%. Comparing base (8f34ae6) to head (86436d4).
⚠️ Report is 16 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
- Coverage   83.59%   83.50%   -0.10%     
==========================================
  Files          26       32       +6     
  Lines        2768     3159     +391     
==========================================
+ Hits         2314     2638     +324     
- Misses        454      521      +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wegank
wegank marked this pull request as draft March 27, 2026 17:31
@wegank
wegank marked this pull request as ready for review March 27, 2026 17:35
@ederc
ederc merged commit f22e334 into algebraic-solving:main Mar 27, 2026
8 checks passed
@ederc

ederc commented Mar 27, 2026

Copy link
Copy Markdown
Collaborator

Works fine, thanks.

@wegank
wegank deleted the oscar-array-fix branch March 27, 2026 18:32
@wegank

wegank commented Mar 27, 2026

Copy link
Copy Markdown
Contributor Author

Oh, I was trying to find the draft button in GitHub mobile (probably it just doesn't exist)... I think this might introduce a memory issue which I can't verify for now.

@wegank

wegank commented Mar 27, 2026

Copy link
Copy Markdown
Contributor Author

False alarm: this doesn't introduce the memory issue I was worried about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conversion problems when calling _groebner_basis_array from Oscar

3 participants