Skip to content

Fix ImGui::PushFont 2-argument API breakage in overlay - #45

Merged
alex47exe merged 2 commits into
devfrom
copilot/fix-github-actions-job-failure
Aug 25, 2026
Merged

Fix ImGui::PushFont 2-argument API breakage in overlay#45
alex47exe merged 2 commits into
devfrom
copilot/fix-github-actions-job-failure

Conversation

Copilot AI commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

ImGui updated PushFont to require an explicit size parameter, breaking the api_experimental release build on VS2026.

Changes

  • overlay_experimental/steam_overlay.cpp: Updated two PushFont calls missing the size argument to match the rest of the file
// Before
ImGui::PushFont(font_default);

// After
ImGui::PushFont(font_default, 0.0f);  // 0.0f = inherit default font size

Co-authored-by: alex47exe <17827464+alex47exe@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job for Emu win all Fix ImGui::PushFont 2-argument API breakage in overlay Aug 25, 2026
Copilot AI requested a review from alex47exe August 25, 2026 00:29
@alex47exe
alex47exe marked this pull request as ready for review August 25, 2026 00:30
Copilot AI lite review requested due to automatic review settings August 25, 2026 00:30
@alex47exe
alex47exe merged commit 643a9fe into dev Aug 25, 2026
1 check passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is minimal, consistent with existing PushFont(..., 0.0f) usage in the same file, and correctly addresses the documented API break.

Pull request overview

Updates the experimental Steam overlay to match a breaking change in Dear ImGui’s ImGui::PushFont API by supplying the newly required size argument, restoring build compatibility for the api_experimental release configuration.

Changes:

  • Updated render_gallery_window() to call ImGui::PushFont(font_default, 0.0f).
  • Updated render_pinned_screenshot() to call ImGui::PushFont(font_default, 0.0f).
File summaries
File Description
overlay_experimental/steam_overlay.cpp Adds the required size parameter to two ImGui::PushFont calls to match the file’s existing usage pattern and fix the ImGui API breakage.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@alex47exe
alex47exe deleted the copilot/fix-github-actions-job-failure branch August 25, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants