Fix ImGui::PushFont 2-argument API breakage in overlay - #45
Merged
Conversation
Co-authored-by: alex47exe <17827464+alex47exe@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job for Emu win all
Fix ImGui::PushFont 2-argument API breakage in overlay
Aug 25, 2026
alex47exe
marked this pull request as ready for review
August 25, 2026 00:30
There was a problem hiding this comment.
🟢 Approval recommended
The change is minimal, consistent with existing PushFont(..., 0.0f) usage in the same file, and correctly addresses the documented API break.
Pull request overview
Updates the experimental Steam overlay to match a breaking change in Dear ImGui’s ImGui::PushFont API by supplying the newly required size argument, restoring build compatibility for the api_experimental release configuration.
Changes:
- Updated
render_gallery_window()to callImGui::PushFont(font_default, 0.0f). - Updated
render_pinned_screenshot()to callImGui::PushFont(font_default, 0.0f).
File summaries
| File | Description |
|---|---|
| overlay_experimental/steam_overlay.cpp | Adds the required size parameter to two ImGui::PushFont calls to match the file’s existing usage pattern and fix the ImGui API breakage. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImGui updated
PushFontto require an explicitsizeparameter, breaking theapi_experimentalrelease build on VS2026.Changes
overlay_experimental/steam_overlay.cpp: Updated twoPushFontcalls missing thesizeargument to match the rest of the file