Skip to content

Allow filtering of console api methods - #12

Open
1le wants to merge 1 commit into
alanshaw:masterfrom
1le:master
Open

Allow filtering of console api methods#12
1le wants to merge 1 commit into
alanshaw:masterfrom
1le:master

Conversation

@1le

@1le 1le commented Sep 20, 2016

Copy link
Copy Markdown

Add parameter for specifying the particular console methods to be removed (eg. only remove "log" and "info" {methods: ["log", "info"]})

@alanshaw

Copy link
Copy Markdown
Owner

This is great! Could you please add a proper test that can be run every time and resolve the conflicts?

@1le
1le force-pushed the master branch 3 times, most recently from 6fd0c6d to 3494d5c Compare October 5, 2016 18:04
@1le

1le commented Oct 5, 2016

Copy link
Copy Markdown
Author

Should be fit for merge. Naming could use some improving. Perhaps:
'isMethod' (ex 'isLog') -> 'isMethodForStrip'
'isConsoleMethod' (ex 'isConsoleLog') -> 'isConsoleAndMethod'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants