Skip to content

Moved login condition out of Trait#46

Open
SwarajKR wants to merge 9 commits into
masterfrom
dashboard
Open

Moved login condition out of Trait#46
SwarajKR wants to merge 9 commits into
masterfrom
dashboard

Conversation

@SwarajKR

@SwarajKR SwarajKR commented Oct 6, 2017

Copy link
Copy Markdown
Collaborator

No description provided.

@SwarajKR SwarajKR closed this Oct 13, 2017

@akhilerm akhilerm left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After moving the login condition, the login is working as expected.

@akhilerm akhilerm reopened this Oct 13, 2017

@akhilerm akhilerm left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not working as expected. can still access another user's file

@akhilerm

Copy link
Copy Markdown
Owner

In fbe4169 user can't cd into another user's directory. Enforced by calculating levels of directory. But if the user is in a question directory cd ../question_name will give output as No such directory

@SwarajKR

Copy link
Copy Markdown
Collaborator Author

in cd path should be calculated as following.
$user_dir should be pwd (execute shell command/use previous pwd)
concat it with $args[0]
session - pwd should be new dir - user's home

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants