You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Restore the exceptiongroup conditional dependency in requirements.txt. Its removal will likely break installation or runtime for users on Python versions older than 3.11.
Why: This suggestion correctly identifies that removing the exceptiongroup dependency will break compatibility for Python versions older than 3.11, which is a critical issue if backward compatibility is intended.
High
General
pin ONNX upper bound
Add an upper-bound constraint to the onnx dependency in pyproject.toml to prevent breaking changes from major version updates.
-"onnx>=1.15.0", # For ONNX model export/modification (not needed for inference)+"onnx>=1.15.0,<2.0.0", # For ONNX model export/modification (not needed for inference)
Apply / Chat
Suggestion importance[1-10]: 5
__
Why: The suggestion correctly proposes adding an upper-bound constraint to the onnx dependency to prevent future breaking changes, which is a good practice for improving dependency stability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Bug fix, Enhancement
Description
Move
onnxfrom required to optional dev-model dependenciesFixes Windows installation issues caused by onnx package
Add clarifying comment about onnx usage for model export
Update requirements.txt with cleaned hash entries
Diagram Walkthrough
File Walkthrough
pyproject.toml
Move onnx to optional dev-model dependenciespyproject.toml
onnx==1.17.0from main dependencies listonnx>=1.15.0to dev-model optional dependenciesnot needed for inference
onnxruntime==1.20.1in main dependenciesrequirements.txt
Remove onnx and cleanup hash entriesrequirements.txt
kiwisolver, matplotlib, numpy, and pyyaml packages
pydantic-core, scikit-learn, scipy, and shapely