Accept Git repository URLs in boulder recipe new - #837
Merged
Conversation
livingsilver94
changed the title
boulder recipe new
livingsilver94
force-pushed
the
boulder_new_git_recipes
branch
2 times, most recently
from
August 1, 2026 15:10
d0c20bc to
db9f41f
Compare
livingsilver94
marked this pull request as ready for review
August 1, 2026 22:07
Member
|
Looks sane to me, but will let a Rust expert chip in. |
tarkah
reviewed
Aug 6, 2026
tarkah
left a comment
tarkah
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Some nice cleanup in here as well. I have just two small comments.
tarkah
approved these changes
Aug 6, 2026
Member
|
@livingsilver94 did you run Because I get failures w/rustc 1.91.1 that look like this: 
|
Member
Author
|
No, I tested it with |
Member
If possible, that would be nice. =) |
livingsilver94
force-pushed
the
boulder_new_git_recipes
branch
from
August 7, 2026 09:26
652ad58 to
a656754
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the
boulder recipe newcommand accept Git-styled URI to create a recipe out of a Git repository. a Git-styled URI is a regular URL prefixed with ourgit|specifier. The recipe created points to the hash of the current HEAD of the repo.I've also simplified URL parsing in
draft::monitoring::githubanddraft::monitoring::gitlab, as in my opinion the regexes were hard to grasp. We're still leveraging regexes (although ideally we would ditch them), but they're shorter and only match the path inside the URL. Other checks are performed using functions provided by theUrlstruct.No functional change is introduced in these two modules except in gitlab's regular expressions, because the original ones weren't matching projects with a dot (".") in their name. In fact, I've also created a test with mesa3d.org's URL.
There's one effort remaining that is not covered in this PR: when running
boulder recipe new <first_url> <second_url>, the command eventually fails because under the hood Git is trying to clone a repo inside the extraction root, that is not empty. Git is not happy about this. #838 will cover this case.Fixes #537.