Skip to content

Fix bugs#53

Open
AltairCA wants to merge 1 commit into
aematsubara:masterfrom
AltairCA:feature/bugfixes
Open

Fix bugs#53
AltairCA wants to merge 1 commit into
aematsubara:masterfrom
AltairCA:feature/bugfixes

Conversation

@AltairCA

@AltairCA AltairCA commented Feb 17, 2025

Copy link
Copy Markdown

Fix bug where giving armor to a village with no armor

and possible fix for this #51

@AltairCA
Fix bugs
f83f90a 
fix bug where giving armor to a village with no armor, and fix build issues
@AltairCA
AltairCA marked this pull request as ready for review February 17, 2025 06:00
@synexo synexo mentioned this pull request Feb 18, 2025
Open
@synexo

synexo commented Feb 18, 2025

Copy link
Copy Markdown

Tested and built successfully but server crashed once running and user log on:

[18:34:46] [Server thread/ERROR]: [ChunkTaskScheduler] Chunk system error at chunk (-37,-310), holder: NewChunkHolder{world=CityWorld, chunkX=-37, chunkZ=-310, entityChunkFromDisk=true, lastChunkCompletion={chunk_class=net.minecraft.world.level.chunk.ImposterProtoChunk,status=minecraft:spawn}, currentGenStatus=minecraft:spawn, requestedGenStatus=minecraft:full, generationTask=ChunkProgressionTask{class: ca.spottedleaf.moonrise.patches.chunk_system.scheduling.task.ChunkFullTask, for world: CityWorld, chunk: (-37,-310), hashcode: 125135724, priority: COMPLETING, status: minecraft:full, scheduled: true}, generationTaskStatus=minecraft:full, priority=null, priorityLocked=false, neighbourRequestedPriority=null, effective_priority=null, oldTicketLevel=33, currentTicketLevel=33, totalNeighboursUsingThisChunk=1, fullNeighbourChunksLoadedBitset=36079, currentChunkStatus=INACCESSIBLE, pendingChunkStatus=INACCESSIBLE, is_unload_safe=ticket_level, killed=false}, exception:
java.lang.Throwable: java.lang.NoSuchMethodError: 'void net.minecraft.world.entity.ai.gossip.GossipContainer.(net.minecraft.world.entity.npc.Villager)'
at ca.spottedleaf.moonrise.patches.chunk_system.scheduling.ChunkTaskScheduler.unrecoverableChunkSystemFailure(ChunkTaskScheduler.java:313) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at ca.spottedleaf.moonrise.patches.chunk_system.scheduling.NewChunkHolder.lambda$setGenerationTask$5(NewChunkHolder.java:1627) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at ca.spottedleaf.moonrise.patches.chunk_system.scheduling.task.ChunkProgressionTask.complete0(ChunkProgressionTask.java:91) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at ca.spottedleaf.moonrise.patches.chunk_system.scheduling.task.ChunkProgressionTask.complete(ChunkProgressionTask.java:74) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at ca.spottedleaf.moonrise.patches.chunk_system.scheduling.task.ChunkFullTask.run(ChunkFullTask.java:94) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at ca.spottedleaf.concurrentutil.executor.queue.PrioritisedTaskQueue$PrioritisedQueuedTask.execute(PrioritisedTaskQueue.java:281) ~[concurrentutil-0.0.3.jar:?]
at ca.spottedleaf.concurrentutil.executor.queue.PrioritisedTaskQueue.executeTask(PrioritisedTaskQueue.java:101) ~[concurrentutil-0.0.3.jar:?]
at ca.spottedleaf.moonrise.patches.chunk_system.scheduling.ChunkTaskScheduler.executeMainThreadTask(ChunkTaskScheduler.java:347) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.level.ServerChunkCache$MainThreadExecutor.pollTask(ServerChunkCache.java:828) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.level.ServerChunkCache.pollTask(ServerChunkCache.java:435) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1435) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1422) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:139) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.MinecraftServer.managedBlock(MinecraftServer.java:1379) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1387) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1264) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:310) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]
Caused by: java.lang.NoSuchMethodError: 'void net.minecraft.world.entity.ai.gossip.GossipContainer.(net.minecraft.world.entity.npc.Villager)'
at RealisticVillagers-3.3.3.6.jar/me.matsubara.realisticvillagers.nms.v1_21_4.CustomGossipContainer.(CustomGossipContainer.java:33) ~[RealisticVillagers-3.3.3.6.jar:?]
at RealisticVillagers-3.3.3.6.jar/me.matsubara.realisticvillagers.entity.v1_21_4.villager.VillagerNPC.(VillagerNPC.java:213) ~[RealisticVillagers-3.3.3.6.jar:?]
at RealisticVillagers-3.3.3.6.jar/me.matsubara.realisticvillagers.entity.v1_21_4.villager.VillagerNPC.(VillagerNPC.java:316) ~[RealisticVillagers-3.3.3.6.jar:?]
at RealisticVillagers-3.3.3.6.jar/me.matsubara.realisticvillagers.nms.v1_21_4.NMSConverter.lambda$registerEntities$1(NMSConverter.java:155) ~[RealisticVillagers-3.3.3.6.jar:?]
at net.minecraft.world.entity.EntityType.create(EntityType.java:1356) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.world.entity.EntityType.lambda$create$25(EntityType.java:1366) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at java.base/java.util.Optional.map(Optional.java:260) ~[?:?]
at net.minecraft.world.entity.EntityType.create(EntityType.java:1366) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.world.entity.EntityType.create(EntityType.java:1361) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.world.entity.EntityType.loadStaticEntity(EntityType.java:1461) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.world.entity.EntityType.loadEntityRecursive(EntityType.java:1404) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.world.entity.EntityType$1.lambda$tryAdvance$1(EntityType.java:1426) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at java.base/java.util.Spliterators$IteratorSpliterator.tryAdvance(Spliterators.java:1950) ~[?:?]
at net.minecraft.world.entity.EntityType$1.tryAdvance(EntityType.java:1426) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at java.base/java.util.Spliterator.forEachRemaining(Spliterator.java:332) ~[?:?]
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) ~[?:?]
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) ~[?:?]
at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921) ~[?:?]
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?]
at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682) ~[?:?]
at ca.spottedleaf.moonrise.patches.chunk_system.level.entity.ChunkEntitySlices.readEntities(ChunkEntitySlices.java:79) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at ca.spottedleaf.moonrise.patches.chunk_system.scheduling.NewChunkHolder.loadInEntityChunk(NewChunkHolder.java:120) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at ca.spottedleaf.moonrise.patches.chunk_system.scheduling.ChunkHolderManager.getOrCreateEntityChunk(ChunkHolderManager.java:949) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at ca.spottedleaf.moonrise.patches.chunk_system.scheduling.task.ChunkFullTask.run(ChunkFullTask.java:84) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
... 13 more
[18:34:47] [Server thread/ERROR]: Encountered an unexpected exception
net.minecraft.ReportedException: Exception ticking world
at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1728) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1529) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1251) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:310) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]
Caused by: java.lang.RuntimeException: Chunk system crash propagated from unrecoverableChunkSystemFailure
at ca.spottedleaf.moonrise.patches.chunk_system.scheduling.ChunkTaskScheduler.lambda$unrecoverableChunkSystemFailure$0(ChunkTaskScheduler.java:336) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at ca.spottedleaf.concurrentutil.executor.queue.PrioritisedTaskQueue$PrioritisedQueuedTask.execute(PrioritisedTaskQueue.java:281) ~[concurrentutil-0.0.3.jar:?]
at ca.spottedleaf.concurrentutil.executor.queue.PrioritisedTaskQueue.executeTask(PrioritisedTaskQueue.java:101) ~[concurrentutil-0.0.3.jar:?]
at ca.spottedleaf.moonrise.patches.chunk_system.scheduling.ChunkTaskScheduler.executeMainThreadTask(ChunkTaskScheduler.java:347) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.level.ServerChunkCache$MainThreadExecutor.pollTask(ServerChunkCache.java:828) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.level.ServerChunkCache.pollTask(ServerChunkCache.java:435) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.MinecraftServer.tickMidTickTasks(MinecraftServer.java:347) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.MinecraftServer.moonrise$executeMidTickTasks(MinecraftServer.java:368) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.level.ServerLevel.moonrise$midTickTasks(ServerLevel.java:332) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.world.level.Level.guardEntityTick(Level.java:1508) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.level.ServerLevel.lambda$tick$4(ServerLevel.java:817) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.world.level.entity.EntityTickList.forEach(EntityTickList.java:39) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.level.ServerLevel.tick(ServerLevel.java:799) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1724) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
... 4 more
Caused by: net.minecraft.ReportedException: Chunk system error
at ca.spottedleaf.moonrise.patches.chunk_system.scheduling.ChunkTaskScheduler.unrecoverableChunkSystemFailure(ChunkTaskScheduler.java:319) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at ca.spottedleaf.moonrise.patches.chunk_system.scheduling.NewChunkHolder.lambda$setGenerationTask$5(NewChunkHolder.java:1627) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at ca.spottedleaf.moonrise.patches.chunk_system.scheduling.task.ChunkProgressionTask.complete0(ChunkProgressionTask.java:91) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at ca.spottedleaf.moonrise.patches.chunk_system.scheduling.task.ChunkProgressionTask.complete(ChunkProgressionTask.java:74) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at ca.spottedleaf.moonrise.patches.chunk_system.scheduling.task.ChunkFullTask.run(ChunkFullTask.java:94) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at ca.spottedleaf.concurrentutil.executor.queue.PrioritisedTaskQueue$PrioritisedQueuedTask.execute(PrioritisedTaskQueue.java:281) ~[concurrentutil-0.0.3.jar:?]
at ca.spottedleaf.concurrentutil.executor.queue.PrioritisedTaskQueue.executeTask(PrioritisedTaskQueue.java:101) ~[concurrentutil-0.0.3.jar:?]
at ca.spottedleaf.moonrise.patches.chunk_system.scheduling.ChunkTaskScheduler.executeMainThreadTask(ChunkTaskScheduler.java:347) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.level.ServerChunkCache$MainThreadExecutor.pollTask(ServerChunkCache.java:828) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.level.ServerChunkCache.pollTask(ServerChunkCache.java:435) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1435) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1422) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:139) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.MinecraftServer.managedBlock(MinecraftServer.java:1379) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1387) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1264) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
... 2 more
Caused by: java.lang.NoSuchMethodError: 'void net.minecraft.world.entity.ai.gossip.GossipContainer.(net.minecraft.world.entity.npc.Villager)'
at RealisticVillagers-3.3.3.6.jar/me.matsubara.realisticvillagers.nms.v1_21_4.CustomGossipContainer.(CustomGossipContainer.java:33) ~[RealisticVillagers-3.3.3.6.jar:?]
at RealisticVillagers-3.3.3.6.jar/me.matsubara.realisticvillagers.entity.v1_21_4.villager.VillagerNPC.(VillagerNPC.java:213) ~[RealisticVillagers-3.3.3.6.jar:?]
at RealisticVillagers-3.3.3.6.jar/me.matsubara.realisticvillagers.entity.v1_21_4.villager.VillagerNPC.(VillagerNPC.java:316) ~[RealisticVillagers-3.3.3.6.jar:?]
at RealisticVillagers-3.3.3.6.jar/me.matsubara.realisticvillagers.nms.v1_21_4.NMSConverter.lambda$registerEntities$1(NMSConverter.java:155) ~[RealisticVillagers-3.3.3.6.jar:?]
at net.minecraft.world.entity.EntityType.create(EntityType.java:1356) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.world.entity.EntityType.lambda$create$25(EntityType.java:1366) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at java.base/java.util.Optional.map(Optional.java:260) ~[?:?]
at net.minecraft.world.entity.EntityType.create(EntityType.java:1366) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.world.entity.EntityType.create(EntityType.java:1361) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.world.entity.EntityType.loadStaticEntity(EntityType.java:1461) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.world.entity.EntityType.loadEntityRecursive(EntityType.java:1404) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.world.entity.EntityType$1.lambda$tryAdvance$1(EntityType.java:1426) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at java.base/java.util.Spliterators$IteratorSpliterator.tryAdvance(Spliterators.java:1950) ~[?:?]
at net.minecraft.world.entity.EntityType$1.tryAdvance(EntityType.java:1426) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at java.base/java.util.Spliterator.forEachRemaining(Spliterator.java:332) ~[?:?]
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) ~[?:?]
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) ~[?:?]
at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921) ~[?:?]
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?]
at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682) ~[?:?]
at ca.spottedleaf.moonrise.patches.chunk_system.level.entity.ChunkEntitySlices.readEntities(ChunkEntitySlices.java:79) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at ca.spottedleaf.moonrise.patches.chunk_system.scheduling.NewChunkHolder.loadInEntityChunk(NewChunkHolder.java:120) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at ca.spottedleaf.moonrise.patches.chunk_system.scheduling.ChunkHolderManager.getOrCreateEntityChunk(ChunkHolderManager.java:949) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at ca.spottedleaf.moonrise.patches.chunk_system.scheduling.task.ChunkFullTask.run(ChunkFullTask.java:84) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at ca.spottedleaf.concurrentutil.executor.queue.PrioritisedTaskQueue$PrioritisedQueuedTask.execute(PrioritisedTaskQueue.java:281) ~[concurrentutil-0.0.3.jar:?]
at ca.spottedleaf.concurrentutil.executor.queue.PrioritisedTaskQueue.executeTask(PrioritisedTaskQueue.java:101) ~[concurrentutil-0.0.3.jar:?]
at ca.spottedleaf.moonrise.patches.chunk_system.scheduling.ChunkTaskScheduler.executeMainThreadTask(ChunkTaskScheduler.java:347) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.level.ServerChunkCache$MainThreadExecutor.pollTask(ServerChunkCache.java:828) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.level.ServerChunkCache.pollTask(ServerChunkCache.java:435) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1435) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1422) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:139) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.MinecraftServer.managedBlock(MinecraftServer.java:1379) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1387) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1264) ~[paper-1.21.4.jar:1.21.4-147-3bd69f2]
... 2 more
[18:34:47] [Server thread/ERROR]: This crash report has been saved to: /opt/vanilla_ish/crash-reports/crash-2025-02-18_18.34.47-server.txt

@AltairCA

AltairCA commented Feb 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Author

Yep had the same error when I use PaperMC, but with Spigot it works, it seems like PaperMC doesn't have the required API's ?

@synexo

synexo commented Feb 20, 2025

Copy link
Copy Markdown

Thanks for letting me know, I may try it with Spigot or see if I can find whether it's something being addressed in Paper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AltairCA @synexo