Update NodeJS / CAP dependencies for frameworks/cap/test/** - #408
Draft
data-douser wants to merge 3 commits into
Draft
Update NodeJS / CAP dependencies for frameworks/cap/test/**#408data-douser wants to merge 3 commits into
frameworks/cap/test/**#408data-douser wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the dependency versions used by CAP/Express-based test fixture projects under javascript/frameworks/cap/test/**, aligning them with newer major releases of @sap/cds, express, and (where present) @sap/cds-dk to keep the fixtures current with upstream CAP/Express changes.
Changes:
- Bumped
@sap/cdsdependency ranges to^10(or^10.0.3in one fixture). - Upgraded
expressacross the affected fixtures to^5.2.1. - Updated
@sap/cds-dkin the fixtures that use it to^10.0.4.
Show a summary per file
| File | Description |
|---|---|
| javascript/frameworks/cap/test/queries/loginjection/log-injection-without-protocol-none/package.json | Bumps CAP + Express dependency ranges for this log-injection fixture. |
| javascript/frameworks/cap/test/queries/loginjection/log-injection-with-service2-protocol-none/package.json | Bumps CAP + Express dependency ranges for this log-injection fixture. |
| javascript/frameworks/cap/test/queries/loginjection/log-injection-with-service1-protocol-none/package.json | Bumps CAP + Express dependency ranges for this log-injection fixture. |
| javascript/frameworks/cap/test/queries/loginjection/log-injection-with-complete-protocol-none/package.json | Bumps CAP + Express dependency ranges for this log-injection fixture. |
| javascript/frameworks/cap/test/queries/loginjection/log-injection-type-sanitized/package.json | Updates CAP, cds-dk, and Express versions for the sanitized log-injection fixture. |
| javascript/frameworks/cap/test/queries/loginjection/log-injection-not-depending-on-request/package.json | Bumps CAP + Express dependency ranges for this log-injection fixture. |
| javascript/frameworks/cap/test/queries/cqlinjection/package.json | Updates CAP, cds-dk, and Express versions for the CQL injection fixture. |
| javascript/frameworks/cap/test/queries/bad-authn-authz/nonprod-authn-strategy/mocked-authentication/package.json | Updates CAP + Express versions for the non-production authn strategy fixture. |
| javascript/frameworks/cap/test/queries/bad-authn-authz/nonprod-authn-strategy/dummy-authentication/package.json | Updates CAP + Express versions for the non-production authn strategy fixture. |
| javascript/frameworks/cap/test/queries/bad-authn-authz/nonprod-authn-strategy/basic-authentication/package.json | Updates CAP + Express versions for the non-production authn strategy fixture. |
| javascript/frameworks/cap/test/queries/bad-authn-authz/misused-privileged-user/unnecessarily-granted-privileged-access-rights/package.json | Updates Express version (and should align CAP versioning intent with PR description). |
| javascript/frameworks/cap/test/queries/bad-authn-authz/misused-privileged-user/default-is-privileged/package.json | Updates CAP + Express versions for privileged-user authn fixture. |
| javascript/frameworks/cap/test/queries/bad-authn-authz/entities-with-no-authz/entities-exposed-with-no-authz/package.json | Updates CAP + Express versions for “no authz” entity exposure fixture. |
| javascript/frameworks/cap/test/queries/bad-authn-authz/entities-with-no-authz/entities-exposed-with-js-authz/package.json | Updates CAP + Express versions for JS authz entity exposure fixture. |
| javascript/frameworks/cap/test/queries/bad-authn-authz/entities-with-no-authz/entities-exposed-with-js-authz-cds-serve/package.json | Updates CAP + Express versions for JS authz entity exposure fixture (cds serve variant). |
| javascript/frameworks/cap/test/queries/bad-authn-authz/entities-with-no-authz/entities-exposed-with-cds-authz/package.json | Updates CAP + Express versions for cds authz entity exposure fixture. |
| javascript/frameworks/cap/test/models/cds/remoteflowsources/package.json | Updates CAP + Express versions for the remote flow sources model fixture. |
| javascript/frameworks/cap/test/models/cds/entityreference/package.json | Updates CAP + Express versions for the entity reference model fixture. |
Review details
- Files reviewed: 18/18 changed files
- Comments generated: 1
- Review effort level: Low
…fixtures Floating ranges (^10, ^10.0.3, ^10.0.4) let CI resolve @sap/cds-dk@10.0.6 (published 2026-07-27), which changed CDS compilation behavior enough to break the @protocol:'none' exclusion and no-authz detection in several unit tests. Pin all cap/test fixtures to the last verified-good release (10.0.5) so builds are deterministic and don't silently regress on upstream patch releases.
Contributor
There was a problem hiding this comment.
Review details
Comments suppressed due to low confidence (3)
javascript/frameworks/cap/test/models/cds/entityreference/package.json:8
- This project has a checked-in package-lock.json, but it still declares
@sap/cdsas "^7" and express as "^4.22.2" (and doesn’t include @sap/cds-dk). With package.json now pinned to@sap/cds10.0.5 / express 5.2.1 /@sap/cds-dk10.0.5, npm installs will be inconsistent and CI may fail with a lockfile mismatch. Regenerate/update the lockfile so it matches the new dependency set.
"@sap/cds": "10.0.5",
"@sap/cds-dk": "10.0.5",
"express": "5.2.1",
"@cap-js/sqlite": "*"
javascript/frameworks/cap/test/queries/bad-authn-authz/misused-privileged-user/unnecessarily-granted-privileged-access-rights/package.json:8
- This project has a checked-in package-lock.json, but it still declares
@sap/cdsas "*" and express as "^4.22.2" (and doesn’t include @sap/cds-dk). With package.json now pinned to@sap/cds10.0.5 / express 5.2.1 /@sap/cds-dk10.0.5, npm installs will be inconsistent and CI may fail with a lockfile mismatch. Regenerate/update the lockfile so it matches the new dependency set.
"@sap/cds": "10.0.5",
"@sap/cds-dk": "10.0.5",
"express": "5.2.1",
"@cap-js/sqlite": "*"
javascript/frameworks/cap/test/queries/loginjection/log-injection-not-depending-on-request/package.json:7
- The PR description says these test projects were updated to use caret ranges (e.g.
@sap/cds"^10" / express "^5.2.1") and mentions@sap/cds-dk"^10.0.4", but this package.json pins exact versions (10.0.5 / 5.2.1) and uses@sap/cds-dk10.0.5. Please align either the dependency specifiers here (and in the other updated package.json files) or update the PR description so it accurately reflects what was changed.
"@sap/cds": "10.0.5",
"@sap/cds-dk": "10.0.5",
"express": "5.2.1"
- Files reviewed: 18/18 changed files
- Comments generated: 0 new
- Review effort level: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This PR Contributes
This pull request updates the dependencies for
frameworks/cap/test/**projects to use the latest major versions of@sap/cds,express, and, where applicable,@sap/cds-dk. These changes help ensure compatibility with the latest features and security updates in the CAP framework and Express.Dependency upgrades:
@sap/cdsto version^10(or^10.0.3where previously pinned) in all affectedpackage.jsonfiles to ensure compatibility with the latest CAP features and fixes. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]expressto version^5.2.1in all affected projects, replacing various older4.xversions to benefit from the latest Express improvements and security patches. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]@sap/cds-dkto version^10.0.4in projects where it was previously specified, ensuring alignment with the main@sap/cdsversion. [1] [2]These updates are important for keeping the test projects up-to-date, secure, and compatible with the latest CAP and Express releases.
Future Works