Skip to content

[media] Fix broken visit link related to multilingual code#11007

Open
HachemJ wants to merge 2 commits into
aces:29.0-releasefrom
HachemJ:FixWrongLinksInMediaModuleIfLanguageNotDefault
Open

[media] Fix broken visit link related to multilingual code#11007
HachemJ wants to merge 2 commits into
aces:29.0-releasefrom
HachemJ:FixWrongLinksInMediaModuleIfLanguageNotDefault

Conversation

@HachemJ

@HachemJ HachemJ commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Brief summary of changes

This PR fixes a bug where row['SessionID'] was undefined when using a language other than English because the row keys were localized (e.g. row['Identifiant de session'] in French).

Testing instructions (if applicable)

  1. git checkout HachemJ/FixWrongLinksInMediaModuleIfLanguageNotDefault
  2. Go to 'Clinical' -> 'Media'
  3. Verify that the entries in the Visit Label column are displayed as clickable links.
  4. Switch the language to 'French'
  5. Verify that the visit labels are translated, remain clickable, and navigate to the same session as in English (i.e., the sessionID in the URL is unchanged)
  6. Make sure the links are clickable in any language.

Link(s) to related issue(s)

@github-actions github-actions Bot added Language: Javascript PR or issue that update Javascript code Module: media PR or issue related to media module labels Jul 24, 2026
@HachemJ HachemJ added Multilingual Any tasks related to making LORIS multilingual 29.0.0 - Bugs Issues found during the release testing for 29.0.0 labels Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

29.0.0 - Bugs Issues found during the release testing for 29.0.0 Language: Javascript PR or issue that update Javascript code Module: media PR or issue related to media module Multilingual Any tasks related to making LORIS multilingual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant