Viewport diagnostics, block labels, and revisiting a finished block - #295
Open
abraraaa wants to merge 5 commits into
Open
Viewport diagnostics, block labels, and revisiting a finished block#295abraraaa wants to merge 5 commits into
abraraaa wants to merge 5 commits into
Conversation
/diag-safe-area now prints whether min-height: stretch and -webkit-fill-available are supported, and the measured .forge-page height against innerHeight.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
/diag-safe-area now prints 100vh/svh/lvh/dvh as measured pixels alongside innerHeight, plus stretch and -webkit-fill-available support and the .forge-page height.
abraraaa
changed the title
The label rendered beside the set/round count in the same grammar, so "Superset · 2 of 3" above "0/4 rounds" read as progress. Position is carried by list order and the exercise names.
abraraaa
changed the title
The set number was clamped onto the block's last set, so a completed block showed "Set 4 of 4" with a primed Log button while the overview called it Done. Unclamped: the masthead says all sets are logged, the pips fill, and adding a further set is an explicit choice. The reach now offers on the last set rather than at-or-past it, so it cannot fire while revisiting.
abraraaa
changed the title
/diag-hdr reports rec2100 and dynamic-range-limit support and the dynamic-range media queries, and offers five pressable panels — control, SDR bloom, two HDR levels, and light behind a translucent sheet — with the bloom tracking the contact point. Nothing the app imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/diag-safe-areanow prints100vh / svh / lvh / dvhas measured pixels, whethermin-height: stretchand-webkit-fill-availableare supported, and.forge-pageheight againstinnerHeight.Block labels drop the
· N of Mordinal — it rendered beside the set/round count in the same grammar, so "Superset · 2 of 3" above "0/4 rounds" read as progress.Flipping back to a finished block no longer clamps the set number onto its last set. The masthead says all sets are logged, the pips fill, and adding a further set is an explicit choice. The reach offers on the last set rather than at-or-past it, so it can't fire while revisiting.
Tests cover the landing maths, the two flow conditions that read it, and the label guard. No layout change.