#903 Selectable solo cert duration - #967
Open
kjporter wants to merge 5 commits into
Open
Conversation
iccowan
reviewed
Aug 6, 2026
iccowan
left a comment
iccowan
left a comment
Member
There was a problem hiding this comment.
Code looks good, just one comment for thoughts. Ready for QA
| </div> | ||
| @if($user->solo_exp == '' || str_contains($user->solo_exp, 'Expired!')) | ||
| <div class="col-sm-6"> | ||
| <label for="solo_duration" class="form-label-date">Solo Certification Duration</label> |
Member
There was a problem hiding this comment.
I'm thinking this isn't a problem (almost didn't leave this comment, but just leaving for thoughts). Should we clarify that this is in days? I feel like there's a case in the future where there could be a solo cert duration that could be confusing if we don't put that this is days. But also, maybe not...
Contributor
Author
There was a problem hiding this comment.
@iccowan added (days) to specify unit of duration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will: