Skip to content

switch to pyproject.toml - #4235

Draft
EvanKrall wants to merge 4 commits into
masterfrom
u/krall/pyproject
Draft

switch to pyproject.toml#4235
EvanKrall wants to merge 4 commits into
masterfrom
u/krall/pyproject

Conversation

@EvanKrall

Copy link
Copy Markdown
Member

No description provided.

…cally reading requirements-minimal.txt and just inline the contents to fix the build
Comment thread pyproject.toml
]

[project.optional-dependencies]
dev = [

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should have the contents of requirements-dev-minimal here

Comment thread pyproject.toml
"virtualenv==20.36.0",
"zake==0.2.2",
]
docs = [

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(this one will probably be harder to deal with, but this should also just have top-level deps)

Comment thread pyproject.toml

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious to see how we handle the yelpy reqs: in my head i've been mulling an approach where we have two pyproject.tomls and 2 poetry.locks + wrappers everywhere to ensure that the right pair is used

(since unless things have changed/i was misunderstanding things last time i looked into this, poetry has no config options and will always look for pyproject.toml/poetry.lock -- and last i looked, i didn't see a good way to handle the internal/external pypi config)

EvanKrall and others added 2 commits February 10, 2026 22:41
Resolved conflicts in setup.py by keeping the minimal version that just
handles scripts alongside pyproject.toml.

Updated pyproject.toml dev dependencies to use top-level deps only
(from requirements-dev-minimal.txt) instead of pinned transitive deps,
addressing PR feedback.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Since we're moving to pyproject.toml for dependency management,
remove the check-requirements step which depends on requirements-minimal.txt.

Update AGENTS.md to reflect the new dependency management approach
using pyproject.toml instead of requirements-tools.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@EvanKrall

Copy link
Copy Markdown
Member Author

I'm cooling on the idea of this PR, probably not worth reworking this stuff unless we go all the way to Poetry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants