sw_apps: zynqmp_fsbl: Mark both RPU cores as used when running in loc… - #386
Open
fr89k wants to merge 1 commit into
Open
sw_apps: zynqmp_fsbl: Mark both RPU cores as used when running in loc…#386fr89k wants to merge 1 commit into
fr89k wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the FSBL loads a partition destined for the RPU in lockstep mode (
XIH_PH_ATTRB_DEST_CPU_R5_L),XFsbl_MarkUsedRPUCores()only set the RPU0 usage bit inXFSBL_R5_USAGE_STATUS_REG, because the lockstep case fell through to the same handling asXIH_PH_ATTRB_DEST_CPU_R5_0.The PMU firmware uses this register to decide which RPU cores it may power down. With
ENABLE_UNUSED_RPU_PWR_DWNenabled,PmForceDownUnusableRpuCores()runs as soon as any master callspm_init_finalize— for example the Linux ZynqMP power driver during boot. Since the RPU1 usage bit was never set, pmufw treated RPU1 as unused and released its power-island, clock, and master requirements, even though in lockstep mode both cores execute the application together. As a result, RPU1 was disabled underneath a running lockstep application.Fix
Give
XIH_PH_ATTRB_DEST_CPU_R5_Lits own case inXFsbl_MarkUsedRPUCores()that sets both the RPU0 and RPU1 usage bits, so pmufw keeps both cores alive.