Skip to content

fix: validate list pagination inputs - #260

Closed
ryanduguid wants to merge 1 commit into
XeroAPI:mainfrom
ryanduguid:fix/validate-pagination-inputs
Closed

fix: validate list pagination inputs#260
ryanduguid wants to merge 1 commit into
XeroAPI:mainfrom
ryanduguid:fix/validate-pagination-inputs

Conversation

@ryanduguid

Copy link
Copy Markdown

Summary

  • accept only positive integer page numbers across paginated list tools
  • retain omitted-page and default-page behavior where supported
  • reject invalid requests before they reach the Xero API

Validation

  • npm test
  • npm run build
  • npm run lint

@ryanduguid

Copy link
Copy Markdown
Author

Closing this one to cut the review load I created here.

I opened a large batch against this repository on 6 August. That was more than any maintainer could reasonably work through, and it was the wrong way to contribute. I have kept open the few changes with the clearest user impact and closed the rest, including this one.

The branch stays on my fork and the change still applies, so if this one is useful, say so and I will reopen it.

@ryanduguid ryanduguid closed this Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant