Skip to content

fix: remove unsupported items page option - #19

Open
ryanduguid wants to merge 1 commit into
XeroAPI:mainfrom
ryanduguid:fix/remove-items-page
Open

fix: remove unsupported items page option#19
ryanduguid wants to merge 1 commit into
XeroAPI:mainfrom
ryanduguid:fix/remove-items-page

Conversation

@ryanduguid

Copy link
Copy Markdown

Summary

  • remove the unsupported items list --page flag and its examples
  • stop passing the former page value as the Xero SDK's unitdp precision parameter
  • add command-level regression coverage for both behaviours

AccountingApi.getItems() has no page parameter; its fifth argument is unitdp. As a result, --page 2 changed decimal precision rather than selecting a second page.

Testing

  • npm test (132 passed)
  • npm run build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant