Skip to content

Update pickpoint API URL - #812

Open
tgilcrest wants to merge 1 commit into
developfrom
bugfix/update-pickpoint-url
Open

Update pickpoint API URL#812
tgilcrest wants to merge 1 commit into
developfrom
bugfix/update-pickpoint-url

Conversation

@tgilcrest

Copy link
Copy Markdown
Collaborator

Overview

An issue with the geocoding was reported by users in Mumbai. I was looking at the failed requests to get a sense of how involved this fix might be. I realized the URL in the pickpoint docs was different, so when I updated that and tested in Postman it worked perfectly. So putting up the change here in hopes it will just work.

Checklist

  • PR has a descriptive enough title to be useful in changelogs
  • PR is targeting the develop branch (unless this is a release)

Demo

Here's the same request we are making in the app (https://pickpoint.io/api/v1/forward?):
image

Here's the request with the URL updated (https://api.pickpoint.io/v1/forward?):
image

Notes

We haven't touched this code in 4 years, so I assume it's a change that Pickpoint made. I looked in our inbox and didn't see any notifications that this was changing, so I'm kind of puzzled how they would just go and make a change like that.

Testing Instructions

  • Load up the environment
  • Create an incident
  • Start typing in the Location box and pickpoint should make a request to search

@tgilcrest
tgilcrest requested a review from ddohler December 18, 2019 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant