Fix edge cases with chat newline rewriter; make it more like vanilla - #696
Merged
Conversation
florianreuth
approved these changes
Jul 2, 2026
florianreuth
left a comment
florianreuth
left a comment
Member
There was a problem hiding this comment.
Fine for now, but ideally this would use MCStructs API instead of raw json object operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr fixes some edge cases and should be more accurate to 1.8 splitting (based on GuiUtilRenderComponents in MCP 1.8.9)
Before:
After:
Test command:
tellraw @a {"text":"","extra":[{"text":"BOLD RED FIRST LINE\n","color":"red","bold":true},{"text":"SECOND LINE SHOULD BE P LAIN WHITE"}]}