fix: don't restore selection - #430
Open
timkambic-ngen wants to merge 1 commit into
Open
Conversation
b-rowan
requested changes
Aug 17, 2026
Comment on lines
+54
to
+59
| // Don't restore selection: Select matches row IDs as CSS selectors, and | ||
| // device IDs may contain invalid chars (e.g. ":") that abort table init. | ||
| stateLoadParams: (settings, data) => { | ||
| // biome-ignore lint/performance/noDelete: selection must not be restored | ||
| delete data.select; | ||
| }, |
Member
There was a problem hiding this comment.
Doesn't this drop the user's selection when the table gets an update (every 3 seconds)? Any chance we can do something to handle those invalid characters (like URL encoding) rather than just deleting the selection?
Comment on lines
+44
to
+47
| stateLoadParams: (settings, data) => { | ||
| // biome-ignore lint/performance/noDelete: selection must not be restored | ||
| delete data.select; | ||
| }, |
Member
There was a problem hiding this comment.
Same idea as above, although much less of an issue as I believe the user table doesn't get updated automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue described here: #428