fix(sixflags): enumerate rides from venue-status and wait-times union#265
Open
kateamllc wants to merge 1 commit into
Open
fix(sixflags): enumerate rides from venue-status and wait-times union#265kateamllc wants to merge 1 commit into
kateamllc wants to merge 1 commit into
Conversation
buildParkLiveData() enumerated rides only from the venue-status feed and treated wait-times as a secondary lookup. A ride the vendor publishes a live wait for, but omits from venue-status, was therefore never iterated and its wait time silently discarded. Because the downstream collector only stamps a record when we emit one, the ride's last stored record was retained indefinitely and served as current. Confirmed at Canada's Wonderland (park 40) on 2026-07-23: "The Daredeviler" (RIDE-040-00072) was serving a 60 minute standby wait in /wait-times, was absent from /venue-status (79 rides) and /poi, and themeparks.wiki had served a CLOSED record frozen since 2026-04-20 while the ride was operating. Rides genuinely removed from a park are absent from wait-times too, so the union only recovers rides the vendor still publishes live data for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildParkLiveData() enumerated rides only from the venue-status feed and treated wait-times as a secondary lookup. A ride the vendor publishes a live wait for, but omits from venue-status, was therefore never iterated and its wait time silently discarded.
Because the downstream collector only stamps a record when we emit one, the ride's last stored record was retained indefinitely and served as current.
Confirmed at Canada's Wonderland (park 40) on 2026-07-23: "The Daredeviler" (RIDE-040-00072) was serving a 60 minute standby wait in /wait-times, was absent from /venue-status (79 rides) and /poi, and themeparks.wiki had served a CLOSED record frozen since 2026-04-20 while the ride was operating.
Rides genuinely removed from a park are absent from wait-times too, so the union only recovers rides the vendor still publishes live data for.