Reduce noise in GS logs caused by gateway disconnections - #7993
Open
vlasebian wants to merge 2 commits into
Open
Reduce noise in GS logs caused by gateway disconnections#7993vlasebian wants to merge 2 commits into
vlasebian wants to merge 2 commits into
Conversation
Bumps the all group with 1 update: [actions/labeler](https://github.com/actions/labeler). Updates `actions/labeler` from 6 to 7 - [Release notes](https://github.com/actions/labeler/releases) - [Commits](actions/labeler@v6...v7) --- updated-dependencies: - dependency-name: actions/labeler dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major dependency-group: all ... Signed-off-by: dependabot[bot] <support@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TLDR; Reduce log noise caused by disconnections logs in tasks and add counter to track reasons for disconnects.
Whenever I try to look for an issue in the GS logs and filter by error level or warning level, I always get these two errors everywhere. It makes it really hard to debug issues and I'd like to change how they are handled so the GS logs are less noisy.
websocket: close 1006 (abnormal closure): unexpected EOF- caused by the gateway's TCP connection dying without a proper websocket close.error:pkg/gatewayserver/io/semtechws:missed_too_many_pongs (gateway missed too many pongs)- happens when the gateway stops responding to the pings of TTS. If the gateway stops responding to pings, the connection gets shut down.These errors are closely related, both refer to disconnections.
Changes
startDisconnectOnChangeTask. The error will be logged on connection tear down.Testing
Unit tests.
Regressions
The
gs.gateway.disconnectevent for these disconnections now carries structured error details instead of a plain string.Notes for Reviewers
None.
Checklist
README.mdfor the chosen target branch.CHANGELOG.md.CONTRIBUTING.md, there are no fixup commits left.