Templatize D2GSPacketSrvStatAndGuid for correct packet sizes - #221
Open
AudriusButkevicius wants to merge 1 commit into
Open
Templatize D2GSPacketSrvStatAndGuid for correct packet sizes#221AudriusButkevicius wants to merge 1 commit into
AudriusButkevicius wants to merge 1 commit into
Conversation
The packet struct was shared across all 5 packet types (9E/9F/A0/A1/A2) with a uint8_t value field, causing truncation for 16-bit and 32-bit variants. Now uses a template parameter for the value type: - 9E, A1: uint8_t (7 bytes) - 9F, A2: uint16_t (8 bytes) - A0: uint32_t (10 bytes) Also enables sizeof() for packet sizes in Server.cpp. Fixes ThePhrozenKeep#172
Mw95
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
D2GSPacketSrvStatAndGuidso each packet variant has the correct value field width:uint8_t(7 bytes)uint16_t(8 bytes)uint32_t(10 bytes)uint8_t nValue, causing value truncation for 16-bit and 32-bit packetssizeof()for packet sizes in Server.cpp (previously hard-coded with sizeof commented out)Fixes #172