Add backup servers

[samuelwei]

Fixes #2095

Type

• Bugfix
• Feature
• Documentation
• Refactoring (e.g. Style updates, Test implementation, etc.)
• Other (please describe):

Checklist

• Code updated to current develop branch head
• Passes CI checks
• Is a part of an issue
• Tests added for the bugfix or newly implemented feature, describe below why if not
• Changelog is updated
• Documentation of code and features exists

Changes

• Add backup servers to server pool

Other information

By default the scheduler picks the server with the lowest usage from a server pool.
If no server in that pool is available, the meeting cannot be started.
This PRs add another fallback, if no server is available, the scheduler picks the server with the lowest usage from the list of backup-servers defined per server pool.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a2a1fd4f-33b5-4e07-90cb-294fd3a6a991

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch adding-backup-servers-to-server-pools

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cypress]

PILOS    Run #3187

Run Properties:   Failed #3187  •  caf378adf1: Add backup servers

Project	PILOS
Branch Review	adding-backup-servers-to-server-pools
Run status	Failed #3187
Run duration	08m 03s
Commit	caf378adf1: Add backup servers
Committer	Samuel Weirich
View all properties for this run ↗︎

---

Test results
Failures	9
Flaky	0
Pending	0
Skipped	0
Passing	626
View all changes introduced in this branch ↗︎

---

Tests for review

  tests/Frontend/e2e/AdminServerPoolsEdit.cy.js • 2 failed tests • Frontend tests

View Output

Test		Artifacts
Admin server pools edit > edit server pool		Test Replay Screenshots
Admin server pools edit > save changes errors		Test Replay Screenshots

  tests/Frontend/e2e/AdminServerPoolsIndex.cy.js • 2 failed tests • Frontend tests

View Output

Test		Artifacts
Admin server pools index > load server pools		Test Replay Screenshots
Admin server pools index > sort server pools		Test Replay Screenshots

  tests/Frontend/e2e/AdminServerPoolsNew.cy.js • 3 failed tests • Frontend tests

View Output

Test		Artifacts
Admin server pools new > add new server pool with 1 server		Test Replay Screenshots
Admin server pools new > add new server pool with several servers		Test Replay Screenshots
Admin server pools new > add new server pool errors		Test Replay Screenshots

  tests/Frontend/e2e/AdminServerPoolsViewServerPoolActions.cy.js • 1 failed test • Frontend tests

View Output

Test		Artifacts
Admin server pools view > switch between edit and view		Test Replay Screenshots

  e2e/RoomsJoinWithLobby.cy.js • 1 failed test • System tests

View Output

Test		Artifacts
Room Join with lobby settings > Lobby enabled		Test Replay Screenshots

[codecov]

Codecov Report

❌ Patch coverage is 0% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.69%. Comparing base (8a7ba9e) to head (caf378a).

Files with missing lines	Patch %	Lines
resources/js/views/AdminServerPoolsView.vue	0.00%	46 Missing ⚠️
resources/js/views/AdminServerPoolsIndex.vue	0.00%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff               @@
##             develop    #3311       +/-   ##
==============================================
- Coverage      97.10%   74.69%   -22.41%     
==============================================
  Files            483      196      -287     
  Lines          16656     9873     -6783     
  Branches        2408     2422       +14     
==============================================
- Hits           16174     7375     -8799     
- Misses           482     2498     +2016     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.