Skip to content

Accessibility: Fix aria descriptions and labels #3298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samuelwei wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Accessibility: Fix aria descriptions and labels #3298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a44fc60
Remove unused aria-describedby
samuelwei Jul 7, 2026
3145b02
Fix broken aria-describedby
samuelwei Jul 7, 2026
95d50b5
Add/Fix labels for select elements
samuelwei Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lang/en/app.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@
'streaming_meeting_not_running' => 'The meeting is not running.',
'streaming_not_enabled_for_current_meeting_error' => 'Streaming is not enabled for the current meeting.',
],
'filter' => 'Filter',
'filter_no_results' => 'No results found',
'firstname' => 'Firstname',
'flash' => [
Expand Down Expand Up @@ -143,6 +144,9 @@
'server_pool' => 'Server pool',
'server_pools' => 'Server pools',
'servers' => 'Server',
'sort_by' => 'Sort by',
'sort_ascending' => 'Sort ascending',
'sort_descending' => 'Sort descending',
'streaming' => 'Streaming',
'time_formats' => [
'day' => 'Day',
Expand Down
1 change: 1 addition & 0 deletions lang/en/rooms.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@
],
'index' => [
'filter' => 'Filter',
'filter_by_room_type' => 'Filter by room type',
'no_favorites' => 'No rooms marked as favorites',
'no_rooms_selected' => 'No rooms selected',
'only_favorites' => 'Only show favorites',
Expand Down
3 changes: 0 additions & 3 deletions resources/js/components/LoginTabLocal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
:disabled="props.loading"
autocomplete="email"
:placeholder="props.emailLabel"
aria-describedby="email-help-block"
:invalid="
props.errors !== null &&
props.errors.email &&
Expand All @@ -34,7 +33,6 @@
fluid
:disabled="props.loading"
:placeholder="props.passwordLabel"
aria-describedby="password-help-block"
:invalid="
props.errors !== null &&
props.errors.password &&
Expand All @@ -43,7 +41,6 @@
/>
<Button
v-if="settingsStore.getSetting('user.password_change_allowed')"
id="password-help-block"
as="router-link"
link
class="self-start p-0"
Expand Down Expand Up @@ -75,7 +72,7 @@

const emit = defineEmits(["submit"]);
const props = defineProps({
errors: {

Check warning on line 75 in resources/js/components/LoginTabLocal.vue

View workflow job for this annotation

GitHub Actions / Frontend Code Style Check 

Prop "errors" should be optional
type: [Object, null],
required: true,
default: null,
Expand Down
11 changes: 9 additions & 2 deletions resources/js/components/RoomTabFiles.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
</search>
<div class="flex flex-col gap-2 lg:flex-row">
<InputGroup v-if="userPermissions.can('manageSettings', props.room)">
<InputGroupAddon>
<InputGroupAddon aria-hidden="true">
<i class="fa-solid fa-filter"></i>
</InputGroupAddon>
<Select
Expand All @@ -75,6 +75,7 @@
option-label="name"
option-value="value"
data-test="filter-dropdown"
:aria-label="$t('app.filter')"
:pt="{
listContainer: {
'data-test': 'filter-dropdown-items',
Expand All @@ -88,7 +89,7 @@
</InputGroup>

<InputGroup data-test="sorting-type-inputgroup">
<InputGroupAddon>
<InputGroupAddon aria-hidden="true">
<i class="fa-solid fa-sort"></i>
</InputGroupAddon>
<Select
Expand All @@ -98,6 +99,7 @@
option-label="name"
option-value="value"
data-test="sorting-type-dropdown"
:aria-label="$t('app.sort_by')"
:pt="{
listContainer: {
'data-test': 'sorting-type-dropdown-items',
Expand All @@ -116,6 +118,11 @@
? 'fa-solid fa-arrow-up-short-wide'
: 'fa-solid fa-arrow-down-wide-short'
"
:aria-label="
sortOrder === 1
? $t('app.sort_ascending')
: $t('app.sort_descending')
"
severity="secondary"
text
class="rounded-l-none"
Expand Down
8 changes: 7 additions & 1 deletion resources/js/components/RoomTabHistory.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
>
<div class="flex gap-2">
<InputGroup class="w-auto" data-test="sorting-type-inputgroup">
<InputGroupAddon>
<InputGroupAddon aria-hidden="true">
<i class="fa-solid fa-sort"></i>
</InputGroupAddon>
<Select
Expand All @@ -21,6 +21,7 @@
:options="sortFields"
option-label="name"
option-value="value"
:aria-label="$t('app.sort_by')"
:pt="{
listContainer: {
'data-test': 'sorting-type-dropdown-items',
Expand All @@ -39,6 +40,11 @@
? 'fa-solid fa-arrow-up-short-wide'
: 'fa-solid fa-arrow-down-wide-short'
"
:aria-label="
sortOrder === 1
? $t('app.sort_ascending')
: $t('app.sort_descending')
"
severity="secondary"
text
class="rounded-l-none"
Expand Down
11 changes: 9 additions & 2 deletions resources/js/components/RoomTabMembers.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
</search>
<div class="flex flex-col gap-2 lg:flex-row">
<InputGroup>
<InputGroupAddon>
<InputGroupAddon aria-hidden="true">
<i class="fa-solid fa-filter"></i>
</InputGroupAddon>
<Select
Expand All @@ -32,6 +32,7 @@
:options="filterOptions"
option-label="name"
option-value="value"
:aria-label="$t('app.filter')"
:pt="{
listContainer: {
'data-test': 'filter-dropdown-items',
Expand All @@ -45,7 +46,7 @@
</InputGroup>

<InputGroup data-test="sorting-type-inputgroup">
<InputGroupAddon>
<InputGroupAddon aria-hidden="true">
<i class="fa-solid fa-sort"></i>
</InputGroupAddon>
<Select
Expand All @@ -55,6 +56,7 @@
:options="sortFields"
option-label="name"
option-value="value"
:aria-label="$t('app.sort_by')"
:pt="{
listContainer: {
'data-test': 'sorting-type-dropdown-items',
Expand All @@ -73,6 +75,11 @@
? 'fa-solid fa-arrow-up-short-wide'
: 'fa-solid fa-arrow-down-wide-short'
"
:aria-label="
sortOrder === 1
? $t('app.sort_ascending')
: $t('app.sort_descending')
"
severity="secondary"
text
class="rounded-l-none"
Expand Down
11 changes: 9 additions & 2 deletions resources/js/components/RoomTabPersonalizedLinks.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
</search>
<div class="flex flex-col gap-2 lg:flex-row">
<InputGroup>
<InputGroupAddon>
<InputGroupAddon aria-hidden="true">
<i class="fa-solid fa-filter"></i>
</InputGroupAddon>
<Select
Expand All @@ -32,6 +32,7 @@
:options="filterOptions"
option-label="name"
option-value="value"
:aria-label="$t('app.filter')"
:pt="{
listContainer: {
'data-test': 'filter-dropdown-items',
Expand All @@ -45,7 +46,7 @@
</InputGroup>

<InputGroup data-test="sorting-type-inputgroup">
<InputGroupAddon>
<InputGroupAddon aria-hidden="true">
<i class="fa-solid fa-sort"></i>
</InputGroupAddon>
<Select
Expand All @@ -55,6 +56,7 @@
:options="sortFields"
option-label="name"
option-value="value"
:aria-label="$t('app.sort_by')"
:pt="{
listContainer: {
'data-test': 'sorting-type-dropdown-items',
Expand All @@ -73,6 +75,11 @@
? 'fa-solid fa-arrow-up-short-wide'
: 'fa-solid fa-arrow-down-wide-short'
"
:aria-label="
sortOrder === 1
? $t('app.sort_ascending')
: $t('app.sort_descending')
"
severity="secondary"
text
class="rounded-l-none"
Expand Down
11 changes: 9 additions & 2 deletions resources/js/components/RoomTabRecordings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
</search>
<div class="flex flex-col gap-2 lg:flex-row">
<InputGroup v-if="userPermissions.can('manageSettings', props.room)">
<InputGroupAddon>
<InputGroupAddon aria-hidden="true">
<i class="fa-solid fa-filter"></i>
</InputGroupAddon>
<Select
Expand All @@ -32,6 +32,7 @@
option-label="name"
option-value="value"
data-test="filter-dropdown"
:aria-label="$t('app.filter')"
:pt="{
listContainer: {
'data-test': 'filter-dropdown-items',
Expand All @@ -45,7 +46,7 @@
</InputGroup>

<InputGroup data-test="sorting-type-inputgroup">
<InputGroupAddon>
<InputGroupAddon aria-hidden="true">
<i class="fa-solid fa-sort"></i>
</InputGroupAddon>
<Select
Expand All @@ -55,6 +56,7 @@
option-label="name"
option-value="value"
data-test="sorting-type-dropdown"
:aria-label="$t('app.sort_by')"
:pt="{
listContainer: {
'data-test': 'sorting-type-dropdown-items',
Expand All @@ -73,6 +75,11 @@
? 'fa-solid fa-arrow-up-short-wide'
: 'fa-solid fa-arrow-down-wide-short'
"
:aria-label="
sortOrder === 1
? $t('app.sort_ascending')
: $t('app.sort_descending')
"
severity="secondary"
text
class="rounded-l-none"
Expand Down
6 changes: 3 additions & 3 deletions resources/js/components/SettingsRoomTypesDeleteButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,11 @@
class="field flex flex-col gap-2"
data-test="replacement-room-type-field"
>
<label for="replacement-room-type">{{
<label id="replacement-room-type-label">{{
$t("admin.room_types.delete.replacement")
}}</label>
<InputGroup>
<Select
id="replacement-room-type"
v-model.number="replacement"
data-test="replacement-room-type-dropdown"
:disabled="
Expand All @@ -49,7 +48,7 @@
option-group-children="items"
option-value="value"
option-label="text"
aria-describedby="replacement-help"
aria-labelledby="replacement-room-type-label"
:pt="{
listContainer: {
'data-test': 'replacement-room-type-dropdown-items',
Expand All @@ -59,6 +58,7 @@
},
optionGroup: 'p-0',
label: {
'aria-describedby': 'replacement-help',
autofocus: true,
},
}"
Expand Down
6 changes: 5 additions & 1 deletion resources/js/views/AdminRoomTypesView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,11 @@
input-id="restrict"
:invalid="formErrors.fieldInvalid('restrict')"
:disabled="isBusy || modelLoadingError || viewOnly"
aria-describedby="restrict-help"
:pt="{
input: {
'aria-describedby': 'restrict-help',
},
}"
/>
</div>
<FormError :errors="formErrors.fieldError('restrict')" />
Expand Down
2 changes: 1 addition & 1 deletion resources/js/views/AdminServersView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@
<fieldset
class="field grid grid-cols-12 gap-4"
data-test="strength-field"
aria-describedby="strength-help"
>
<legend class="col-span-12 md:col-span-4 md:mb-0">
{{ $t("admin.servers.strength") }}
Expand All @@ -150,7 +151,6 @@
:disabled="isBusy || modelLoadingError || viewOnly"
:invalid="formErrors.fieldInvalid('strength')"
:stars="10"
aria-describedby="strength-help"
class="flex justify-between rounded-border border border-surface-300 px-6 py-3 dark:border-surface-600"
data-test="strength-rating"
:pt="{
Expand Down
8 changes: 4 additions & 4 deletions resources/js/views/AdminSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -893,7 +893,7 @@
:disabled="disabled"
aria-labelledby="room-personalized-link-expiration-label"
:pt="{
input: {
label: {
'aria-describedby':
'room-personalized-link-expiration-help',
},
Expand Down Expand Up @@ -943,7 +943,7 @@
:disabled="disabled"
aria-labelledby="room-auto-delete-deadline-period-label"
:pt="{
input: {
label: {
'aria-describedby':
'room-auto-delete-deadline-period-help',
},
Expand Down Expand Up @@ -991,7 +991,7 @@
:disabled="disabled"
aria-labelledby="room-auto-delete-inactive-period-label"
:pt="{
input: {
label: {
'aria-describedby':
'room-auto-delete-inactive-period-help',
},
Expand Down Expand Up @@ -1041,7 +1041,7 @@
:disabled="disabled"
aria-labelledby="room-auto-delete-never-used-period-label"
:pt="{
input: {
label: {
'aria-describedby':
'room-auto-delete-never-used-period-help',
},
Expand Down
6 changes: 5 additions & 1 deletion resources/js/views/AdminUsersNew.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,11 @@
input-id="generate_password"
:invalid="formErrors.fieldInvalid('generate_password')"
:disabled="isBusy"
aria-describedby="generate_password-help"
:pt="{
input: {
'aria-describedby': 'generate_password-help',
},
}"
/>
</div>
<FormError :errors="formErrors.fieldError('generate_password')" />
Expand Down
Loading
Loading