fix(select): wcag fixes #58 - #767
Conversation
|
Warning Review limit reached
Next review available in: 51 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughSelect accessibility and touch interaction behavior were updated through resolved react-select IDs, filtered descriptions, localized removable-value labels, soft-keyboard suppression, placeholder styling changes, regression tests, and new or corrected stories. ChangesSelect accessibility
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant Select
participant ReactSelect
User->>Select: tap select control
Select->>Select: determine pointer target
Select->>ReactSelect: pass softKeyboardSuppressed
ReactSelect->>Select: render input with resolved IDs
User->>Select: tap input
Select->>ReactSelect: allow soft keyboard
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/tedi/components/form/select/select.stories.tsx`:
- Line 69: Update the Select invocation in the small-size story so `{...args}`
is spread before the explicit `size="small"` prop, ensuring the Small variant
always overrides any value supplied through args while preserving the existing
label and id props.
In `@src/tedi/components/form/select/select.tsx`:
- Line 712: Update the Select input’s id assignment near resolvedId so a labeled
InputGroup uses the group’s inputId unchanged rather than appending “-input”;
preserve the existing derived id behavior for standalone Select instances. Add a
regression test covering Select inside a labeled InputGroup and verify the
external label targets the rendered combobox.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: c8ec908a-3b37-4dff-ac5a-9fdb3ebb4bb6
📒 Files selected for processing (7)
src/tedi/components/form/select/components/select-input.tsxsrc/tedi/components/form/select/components/select-multi-value-remove.tsxsrc/tedi/components/form/select/components/select-multi-value.tsxsrc/tedi/components/form/select/select.module.scsssrc/tedi/components/form/select/select.spec.tsxsrc/tedi/components/form/select/select.stories.tsxsrc/tedi/components/form/select/select.tsx
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/tedi/components/form/select/select.tsx`:
- Line 831: Scope handlePointerDownCapture in the select rendering flow to the
react-select control rather than the wrapper containing FormLabel and
FeedbackText, or explicitly ignore and reset events whose target is outside
.tedi-select__control. Preserve keyboard-suppression behavior for pointer events
originating within the select control.
- Around line 514-516: Update handlePointerDownCapture so the early-return path
for openKeyboardOnTouch or !isSearchable also clears suppressSoftKeyboard,
ensuring inputMode is no longer suppressed after configuration changes. Preserve
the existing pointer-type handling for enabled, searchable selects.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 95b33d9b-6b02-4f06-a14c-c7545c34c5b0
📒 Files selected for processing (4)
src/tedi/components/form/select/components/select-input.tsxsrc/tedi/components/form/select/select.spec.tsxsrc/tedi/components/form/select/select.stories.tsxsrc/tedi/components/form/select/select.tsx
🚧 Files skipped from review as they are similar to previous changes (2)
- src/tedi/components/form/select/components/select-input.tsx
- src/tedi/components/form/select/select.spec.tsx
1 participant
Summary by CodeRabbit