Skip to content

fix(table): prevent update loop on server side pagination #733 #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
airikej merged 1 commit into from
Jul 29, 2026
Merged

fix(table): prevent update loop on server side pagination #733 #761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/tedi/components/content/table/table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,11 +410,14 @@ export interface TableProps<TData> {
pagination?: boolean | TablePaginationOptions;
/**
* Whether the current page resets to the first page whenever `data` changes
* (TanStack's `autoResetPageIndex`). Defaults to `true`, which keeps the user
* on a valid page after filtering or sorting. Set to `false` for tables that
* mutate `data` in place — e.g. inline row editing — so saving a row doesn't
* yank the user back to page 1.
* @default true
* (TanStack's `autoResetPageIndex`). Defaults to `true` for client-side
* pagination (keeps the user on a valid page after filtering or sorting) and
* to `false` when `manualPagination` is set — in server-side mode `data` is
* replaced on every page/sort change, so auto-resetting would bounce the user
* back to page 1 and trigger an update loop. Set to `false` for client-side
* tables that mutate `data` in place (e.g. inline row editing), or override
* explicitly in either mode.
* @default true (client-side) / false (manualPagination)
*/
autoResetPageIndex?: boolean;
/**
Expand Down Expand Up @@ -783,7 +786,7 @@ function TableBase<TData>(props: TableProps<TData>): JSX.Element {
expandTrigger = 'button',
paginateExpandedRows = false,
pagination: paginationProp,
autoResetPageIndex = true,
autoResetPageIndex,
manualPagination = false,
manualSorting = false,
manualFiltering = false,
Expand Down Expand Up @@ -1073,7 +1076,7 @@ function TableBase<TData>(props: TableProps<TData>): JSX.Element {
enableRowSelection,
enableMultiRowSelection: selectionMode !== 'single',
enableColumnFilters,
autoResetPageIndex,
autoResetPageIndex: autoResetPageIndex ?? !manualPagination,
paginateExpandedRows: paginationEnabled && !manualPagination ? paginateExpandedRows : true,
manualPagination,
manualSorting,
Expand Down
Loading