Skip to content

fix(date-picker): fix DatePicker focus ring #560 - #574

Open
ly-tempel-bitweb wants to merge 1 commit into
rcfrom
fix/560-date-picker-broken-focus-ring
Open

fix(date-picker): fix DatePicker focus ring #560#574
ly-tempel-bitweb wants to merge 1 commit into
rcfrom
fix/560-date-picker-broken-focus-ring

Conversation

@ly-tempel-bitweb

@ly-tempel-bitweb ly-tempel-bitweb commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

https://storybook.tedi.ee/angular/fix/560-date-picker-broken-focus-ring/?path=/docs/tedi-ready-components-form-datepicker--docs

Summary by CodeRabbit

  • Bug Fixes
    • Improved date picker input styling by ensuring the background remains transparent in both enabled and disabled states.

@ly-tempel-bitweb ly-tempel-bitweb linked an issue Jul 30, 2026 that may be closed by this pull request
21 tasks
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The date picker input styling explicitly sets a transparent background for both the default and disabled states.

Changes

Date picker styling

Layer / File(s) Summary
Set transparent input backgrounds
tedi/components/form/date-picker/date-picker.component.scss
The default and disabled date picker input states explicitly use background: transparent.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related issues

Suggested reviewers: mart-sessman

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the apparent intent of the styling change: fixing the date picker focus ring by adjusting the input background.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Fix failing CI checks
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/560-date-picker-broken-focus-ring

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DatePicker]: broken focus ring in RC

1 participant