enforce mandate spending caps with pre-flight balance check - #185
Open
BigMick03 wants to merge 3 commits into
Open
enforce mandate spending caps with pre-flight balance check#185BigMick03 wants to merge 3 commits into
BigMick03 wants to merge 3 commits into
Conversation
Add InsufficientBalanceError and assertSufficientBalance to mandate guards. Integrate SAC balance query into runBidderAgent via createSacBalanceReader, checking that the session account holds enough escrow token before committing. New usdcSacId field on BidderAgentConfig (required). Includes pure-function unit tests for sufficient/insufficient balance, negative-cap regression test, e2e script update, and README documenting the full guard-rail table.
|
@BigMick03 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #159
Pre-flight check comparing bid + escrow against mandate cap and balance.
Clear typed error when a bid would exceed the cap.
Tests for within-cap, over-cap, and insufficient-balance cases.
Behavior documented.