Solution (#4955): v26.1 Qt6 regression: Application forces fullscreen on launch and - #5043
Solution (#4955): v26.1 Qt6 regression: Application forces fullscreen on launch and#5043TFGSUMIT wants to merge 1 commit into
Conversation
…s fullscreen on launc
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
|
Erm... this bunch of code doesn't do anything to address the issue...
…On Thu, 16 Jul 2026, 18:47 github-actions[bot], ***@***.***> wrote:
*github-actions[bot]* left a comment (Stellarium/stellarium#5043)
<#5043 (comment)>
Great PR! Please pay attention to the following items before merging:
*Files matching src/**/*.cpp:*
- Are possibly unused includes removed?
This is an automatically generated QA checklist based on modified files.
—
Reply to this email directly, view it on GitHub
<#5043?email_source=notifications&email_token=ABQU3MROA7PJ23CLVOU25ZL5FCXEHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJZGA4TKNRWHA3KM4TFMFZW63VQOJSXM2LFO5PXEZLROVSXG5DFMSSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4990956686>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQU3MROXIFSFKQV2RYLX635FCXEHAVCNFSNUABEKJSXA33TNF2G64TZHMYTQNZRHE4DKNR3JFZXG5LFHM2DSMBRGIZDANRSGSQXMAQ>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/ABQU3MRENLHBFDPBKK7HKND5FCXEHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJZGA4TKNRWHA3KM4TFMFZW63VQOJSXM2LFO5PXEZLROVSXG5DFMSSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/ABQU3MSD67Q5IHYWXBWKQT35FCXEHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJZGA4TKNRWHA3KM4TFMFZW63VQOJSXM2LFO5PXEZLROVSXG5DFMSSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Yeah its probably 100% AI. The account has created 100+ repositories this month, probably to throw PRs at any issue that the AI agent found while scanning Github automatically. Seems to be the same situation with #5040 .. very weird Github history, crazy amounts of PRs per month all with totally different programming languages. |
|
I agree that this is obviously just AI slop. When one uses an AI agent, it's the user's job to review and test what it generates, not that of the upstream developers who have to review the resulting PRs. Here the OP seems to not have even read what was generated, nor to have run Stellarium after applying the patch to see if the issue was actually fixed. |
3 participants
This pull request fixes the regression in Stellarium where the application forces fullscreen on launch and ignores saved window geometry on 4K displays. The fix involves reverting the changes made in version 26.1 that caused the fullscreen mode to be forced and fixing the bug that causes the saved window geometry to be ignored.
To test this fix, please follow these steps:
testsdirectory.cmakeandmaketo build the test../mainwindow_test.The test case
testSaveRestoreGeometryis added to ensure that the window geometry is correctly saved and restored. This test case checks that the window size is restored correctly after saving and restoring the geometry.