Skip to content

test: post state transitions with deliverImmediately and assert after termination #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarshallOfSound merged 1 commit into from
May 4, 2026
Merged

test: post state transitions with deliverImmediately and assert after termination #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions SquirrelTests/SQRLUpdaterSpec.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,15 +663,17 @@ bool isRunningOnReadOnlyVolumeImp(id self, SEL _cmd)
}];

NSRunningApplication *testApplication = launchWithEnvironment(nil);
expect(@(testApplication.terminated)).withTimeout(SQRLLongTimeout).toEventually(beTruthy());

// The app has run to completion; every state notification has been
// posted (with deliverImmediately:YES). Allow notifyd a moment to
// deliver any in-flight notifications before asserting the sequence.
NSArray *expectedStates = @[
@(SQRLUpdaterStateIdle),
@(SQRLUpdaterStateCheckingForUpdate),
@(SQRLUpdaterStateIdle),
];
expect(states).toEventually(equal(expectedStates));

expect(@(testApplication.terminated)).withTimeout(SQRLLongTimeout).toEventually(beTruthy());
expect(states).withTimeout(SQRLLongTimeout).toEventually(equal(expectedStates));
});

it(@"should transition through idle, checking, downloading and awaiting relaunch, when there is an update", ^{
Expand All @@ -693,16 +695,18 @@ bool isRunningOnReadOnlyVolumeImp(id self, SEL _cmd)
writeUpdate(update);

NSRunningApplication *testApplication = launchWithEnvironment(nil);
expect(@(testApplication.terminated)).withTimeout(SQRLLongTimeout).toEventually(beTruthy());

// The app has run to completion; every state notification has been
// posted (with deliverImmediately:YES). Allow notifyd a moment to
// deliver any in-flight notifications before asserting the sequence.
NSArray *expectedStates = @[
@(SQRLUpdaterStateIdle),
@(SQRLUpdaterStateCheckingForUpdate),
@(SQRLUpdaterStateDownloadingUpdate),
@(SQRLUpdaterStateAwaitingRelaunch),
];
expect(states).withTimeout(SQRLLongTimeout).toEventually(equal(expectedStates));

expect(@(testApplication.terminated)).withTimeout(SQRLLongTimeout).toEventually(beTruthy());
});
});

Expand Down
2 changes: 1 addition & 1 deletion TestApplication/TestAppDelegate.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ - (void)applicationDidFinishLaunching:(NSNotification *)aNotification {
[RACObserve(self.updater, state) subscribeNext:^(NSNumber *state) {
NSLog(@"State transition: %@", state);

[NSDistributedNotificationCenter.defaultCenter postNotificationName:SQRLTestAppUpdaterStateTransitionNotificationName object:nil userInfo:@{ SQRLTestAppUpdaterStateKey: state }];
[NSDistributedNotificationCenter.defaultCenter postNotificationName:SQRLTestAppUpdaterStateTransitionNotificationName object:nil userInfo:@{ SQRLTestAppUpdaterStateKey: state } deliverImmediately:YES];
}];

__block NSUInteger updateCheckCount = 1;
Expand Down
Loading