Skip to content

Consolidate RDF forms in its own lib - #277

Closed
timea-solid wants to merge 1 commit into
mainfrom
rdfForms
Closed

Consolidate RDF forms in its own lib#277
timea-solid wants to merge 1 commit into
mainfrom
rdfForms

Conversation

@timea-solid

@timea-solid timea-solid commented Jun 2, 2026

Copy link
Copy Markdown
Member

moved registrationControl over from solid-ui #778

@timea-solid timea-solid self-assigned this Jun 2, 2026
Copilot AI review requested due to automatic review settings June 2, 2026 10:06
@timea-solid timea-solid moved this to In progress in SolidOS NLNet UI Jun 2, 2026
@timea-solid timea-solid changed the title Consolidate RDF forms in own lib Consolidate RDF forms in its own lib Jun 2, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates the “registrationControl” UI (previously provided by solid-ui) into this repository, aligning with the goal of keeping RDF form/registration-related UI in a dedicated library/module.

Changes:

  • Added a new src/sharing.js module exporting registrationControl, implemented using solid-logic, rdflib, and solid-ui utilities.
  • Updated src/contactsPane.js to import and call the local registrationControl instead of UI.login.registrationControl.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/sharing.js Introduces the local registrationControl implementation used to manage type index registrations.
src/contactsPane.js Switches the Sharing footer action to use the locally provided registrationControl.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/sharing.js
scope.index
)
}
/// / body of registrationControl
@bourgeoa

bourgeoa commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Is this function used to declare the contacts link in typeIndex's ?
If this is the case it is used in all app-panes, like chat, issue....

We shall not duplicate these high level functions or move them elsewhere. in solid-logic ?

Can we discuss this in team meeting.

@timea-solid

Copy link
Copy Markdown
Member Author

@bourgeoa contacts pane is the only place this function is in use.

@timea-solid

Copy link
Copy Markdown
Member Author

This is not needed at the moment. Reconsider maybe as part of the redesign of the sharing pane.

@github-project-automation github-project-automation Bot moved this from In progress to Done in SolidOS NLNet UI Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants