Consolidate RDF forms in its own lib - #277
Conversation
There was a problem hiding this comment.
Pull request overview
This PR consolidates the “registrationControl” UI (previously provided by solid-ui) into this repository, aligning with the goal of keeping RDF form/registration-related UI in a dedicated library/module.
Changes:
- Added a new
src/sharing.jsmodule exportingregistrationControl, implemented usingsolid-logic,rdflib, andsolid-uiutilities. - Updated
src/contactsPane.jsto import and call the localregistrationControlinstead ofUI.login.registrationControl.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/sharing.js | Introduces the local registrationControl implementation used to manage type index registrations. |
| src/contactsPane.js | Switches the Sharing footer action to use the locally provided registrationControl. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| scope.index | ||
| ) | ||
| } | ||
| /// / body of registrationControl |
|
Is this function used to declare the contacts link in typeIndex's ? We shall not duplicate these high level functions or move them elsewhere. in solid-logic ? Can we discuss this in team meeting. |
|
@bourgeoa contacts pane is the only place this function is in use. |
|
This is not needed at the moment. Reconsider maybe as part of the redesign of the sharing pane. |
moved registrationControl over from solid-ui #778