WWSTCERT-13068 - add aeotec 8 series new - #2897
Open
iot-holding wants to merge 16 commits into
Open
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
Test Results 73 files 542 suites 0s ⏱️ Results for commit afa68dd. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against a01294e |
|
Invitation URL: |
cjswedes
requested changes
Apr 14, 2026
Contributor
There was a problem hiding this comment.
This subdriver is unnecessary. The aeotec-door-window-sensor-8 handlers cover everything here. Remove this driver, and have the device be handled by that one.
Contributor
|
I will re-review once the tests are passing. Ill also request that you test your device on a real hub to ensure its functionality is what you expect. |
KKlimczukS
changed the title
cjswedes
reviewed
Apr 20, 2026
cjswedes
reviewed
Apr 20, 2026
Contributor
There was a problem hiding this comment.
This file must also have a weird name
cjswedes
reviewed
Apr 20, 2026
Contributor
|
@iot-holding once you resolve the branch conflicts and ensure the tests are passing, we can re-review this PR. |
Contributor
|
@cjswedes @aleclorimer could you re-review this? |
aleclorimer
reviewed
May 15, 2026
Contributor
There was a problem hiding this comment.
This can handle never returns true and no longer loads the sub_driver when returning.
aleclorimer
requested changes
May 15, 2026
aleclorimer
left a comment
aleclorimer
left a comment
Contributor
There was a problem hiding this comment.
Look like a couple of @cjswedes comments were still not addressed and a lot of driver tests are broken.
Contributor
|
Hi @iot-holding, let us know when the comments/tests have been addressed and you're ready for us to re-review. |
|
zwave-sensor_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against afa68dd |
|
Profile category check: ✅ Passed - all profiles have a category defined. |
Contributor
Author
|
I apologize for the delay. All open issues should have been addressed in the latest commits. If there are still any issues, please let me know. |
KKlimczukS
changed the title
Contributor
|
Hi @iot-holding, thanks for making the changes. Could you update this branch from main and we'll re-review. |
cjswedes
reviewed
Jul 31, 2026
cjswedes
reviewed
Jul 31, 2026
cjswedes
reviewed
Jul 31, 2026
cjswedes
reviewed
Jul 31, 2026
cjswedes
reviewed
Jul 31, 2026
cjswedes
reviewed
Jul 31, 2026
cjswedes
reviewed
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
This is a new clean pull request for the new Aeotec Series 8 devices.
Summary of Completed Tests