fix: mark $previous parameter as explicitly nullable for PHP 8.4 - #18
Open
xelan wants to merge 1 commit into
Open
fix: mark $previous parameter as explicitly nullable for PHP 8.4#18xelan wants to merge 1 commit into
xelan wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
PR Summary by QodoDeclare TcpSocketException previous cause nullable for PHP 8.4
AI Description
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all |
Author
|
I deliberately kept this PR as small as possible for PHP 8.4 support without deprecations, but keeping BC with the currently supported PHP versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implicitly nullable parameters missing the nullable modifier (e.g.
function($param = null)instead offunction(?$param = null)) are deprecated in PHP 8.4.This PR fixes the deprecation, only
TcpSocketException::__construct()is currently affected by this issue.