The Dockerfile had far more problems than I thought - #2
Open
rf2485 wants to merge 1 commit into
Open
Conversation
Summary of changes: - the python version is pinned to 3.12 to avoid drifting to incompatible python versions. 3.12-slim is used to save space. - environment language is explicitly set to C.UTF-8 for building MP2Proc - WORKDIR is /opt/MP2Proc instead of /root, because otherwise there are permissions errors when running with singularity. It's also more secure. - necessary packages for building MP2Proc are installed with apt-get, including build-essential, make, and libniftiio - symlinks libboost_timer.so to libboost_timer.so.1.83.0 - compiles stubs for RNifti and ANTS - pip install --no-cache-dir to save space - builds MP2Proc using make release - tests MP2Proc so errors are caught upon building the image, rather than having the create and run the container for testing The call to run the program in the container is /opt/MP2Proc/bin/main Getting this Dockerfile to work gave me angina.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes:
The call to run the program in the container is /opt/MP2Proc/bin/main
Getting this Dockerfile to work gave me angina.