Skip to content

new setLore funciton in style of setCustomName - #53

Open
flerbuster wants to merge 1 commit into
SilkMC:mainfrom
flerbuster:main
Open

new setLore funciton in style of setCustomName#53
flerbuster wants to merge 1 commit into
SilkMC:mainfrom
flerbuster:main

Conversation

@flerbuster

Copy link
Copy Markdown

it feels wrong calling setLore like this

setLore(listOf(literalText(...) { ... }...

@jakobkmar

Copy link
Copy Markdown
Member

This seems counter intuitive, since this would add multiple lines even without calling newLine().
For example, simpling changing the color would result in a new line (if you do not wrap every line in a dummy text component).

This function should search for \n instead.

@r0yzer

r0yzer commented Mar 4, 2024

Copy link
Copy Markdown

ich hab rr kein plan was du damit meinst

@flerbuster

Copy link
Copy Markdown
Author

ich rr auch nicht

@flerbuster

Copy link
Copy Markdown
Author

hatte genug

@jakobkmar

jakobkmar commented Mar 4, 2024

Copy link
Copy Markdown
Member

One sibling != one line.

A component is broken down into more parts than just lines, styling, color and interactivity changes also result in more siblings.

@flerbuster

flerbuster commented Mar 4, 2024

Copy link
Copy Markdown
Author

One sibling != one line.

A component is broken down into more parts than just lines, styling, color and interactivity changes also result in more siblings.

can you not just do a sibling in the sibling of the sibling and achieve the same thing

@jakobkmar

Copy link
Copy Markdown
Member

can you not just do a sibling in the sibling of the sibling and achieve the same thing

That would be very very unintuitive. It should be newLine() -> a line break will be inserted.

@flerbuster

Copy link
Copy Markdown
Author

sibling

tmm

@SilkMC SilkMC deleted a comment from flerbuster Mar 4, 2024
@flerbuster

Copy link
Copy Markdown
Author

i will see what i can do but i think i am not smart genug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants