Skip to content

Config source falloff - #96

Open
krisvanneste wants to merge 8 commits into
SeismicSource:mainfrom
krisvanneste:config_source_falloff
Open

Config source falloff#96
krisvanneste wants to merge 8 commits into
SeismicSource:mainfrom
krisvanneste:config_source_falloff

Conversation

@krisvanneste

Copy link
Copy Markdown
Collaborator

This branch allows to configure source spectral falloff through a new source_falloff_power configuration option.
It also contains a bugfix in the _interpolate_data_to_new_freq function in spectrum.py.

@claudiodsf

Copy link
Copy Markdown
Member

Hi Kris,
Thanks for this PR!

Quick reaction from my phone, while I'm on my way to vacation.

I saw you caught a bug in spectrum interpolation. That was a recent change I made for the work we are doing with Aurore.
Do you mind commuting this bug fix directly to main, so that Aurore can use it right away?

Thanks!
Claudio

@krisvanneste

Copy link
Copy Markdown
Collaborator Author

Hi Kris, Thanks for this PR!

Quick reaction from my phone, while I'm on my way to vacation.

I saw you caught a bug in spectrum interpolation. That was a recent change I made for the work we are doing with Aurore. Do you mind commuting this bug fix directly to main, so that Aurore can use it right away?

Thanks! Claudio

OK, I will try to figure out how to do this.
The problem occurred because you compared two arrays with possibly different lengths.

@krisvanneste

Copy link
Copy Markdown
Collaborator Author

OK, I will try to figure out how to do this.
The problem occurred because you compared two arrays with possibly different lengths.

I couldn't push from my working copy, but I was able to make the change directly on the github website.
I hope it's OK!
Kris

@claudiodsf

Copy link
Copy Markdown
Member

Thanks Kris!

Not sure if you did this already, but you can now rebase this PR on main and remove the bugfix commit from here.

Thanks again!
Claudio

@krisvanneste

Copy link
Copy Markdown
Collaborator Author

Thanks Kris!

Not sure if you did this already, but you can now rebase this PR on main and remove the bugfix commit from here.

Thanks again! Claudio

@claudiodsf

I rebased my local copy on the updated main branch:
image

Pushing to github failed however, so I think I need to force push now. Is this OK?

Kris

@claudiodsf

Copy link
Copy Markdown
Member

Yes, force-push !

@krisvanneste
krisvanneste force-pushed the config_source_falloff branch from 8a9135b to e201bb3 Compare July 22, 2026 15:50
@krisvanneste

Copy link
Copy Markdown
Collaborator Author

Yes, force-push !

Done.

The commit with the bugfix automatically disappeared (at least on my side).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants