tests: Added FlowTests for the Seed Backup Verification Flow - #958
Open
PROWLERx15 wants to merge 2 commits into
Open
tests: Added FlowTests for the Seed Backup Verification Flow#958PROWLERx15 wants to merge 2 commits into
PROWLERx15 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements end-to-end FlowTests for the Seed Backup Verification Flow.
Problem or Issue being addressed
My AST Navigation Graph Extractor or the "SeedSigner Views Edge Crawler" (Summer of Bitcoin Project) identified that the entire SeedWords backup verification flow has no FlowTest coverage.
Solution
SKIPbutton routes pending seeds back toSeedFinalizeViewand finalized seeds back toSeedOptionsView.Keepbutton routing on theSeedDiscardView. Verified that pending seeds correctly return toSeedFinalizeViewand finalized seeds correctly return toSeedOptionsViewwhen the user chooses to keep their seed.verify_word_indexandselect_wrong_wordhelper methods to handle the randomized button layout deterministically during testing.Additional Information
The Crawler identified 16 edges in the Seed Backup Flow that previously had 0% FlowTest coverage. The tests added in this PR successfully cover 100% of the previously untested edges listed below:
This pull request is categorized as a:
Checklist
I ran
pytestlocallyI included screenshots of any new or modified screens
Should be part of the PR description above.
I added or updated tests
Any new or altered functionality should be covered in a unit test. Any new or updated sequences require FlowTests.
I tested this PR hands-on on the following platform(s):
I have reviewed these notes: