Revert "Fix membase json" - #1394
Merged
Merged
Conversation
Contributor
PR Summary by QodoRevert Membase JSON handling changes and relax OpenAI settings validation
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
Contributor
Code Review by Qodo
1. Null settings dereference
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
-12
to
-15
| if (settings == null && string.IsNullOrEmpty(apiKey)) | ||
| { | ||
| throw new InvalidOperationException($"No LLM model settings found for '{provider}.{model}'. Register the model under LlmProviders (appsettings/user secrets) or pass an api key."); | ||
| } |
Contributor
There was a problem hiding this comment.
1. Null settings dereference 🐞 Bug ☼ Reliability
ProviderHelper.GetClient can now throw NullReferenceException when ILlmProviderService.GetSetting returns null and apiKey is null, because it still evaluates settings!.ApiKey. This regresses from a clear InvalidOperationException explaining how to configure the model/key.
Agent Prompt
### Issue description
`ProviderHelper.GetClient` no longer validates the case where both the configured model setting is missing and the caller did not provide an API key, leading to a `NullReferenceException` from `settings!.ApiKey`.
### Issue Context
`ILlmProviderService.GetSetting` explicitly returns null when provider/model settings are not found, and several OpenAI providers call `ProviderHelper.GetClient(..., apiKey: null, ...)`, making the null-settings path reachable.
### Fix Focus Areas
- src/Plugins/BotSharp.Plugin.OpenAI/Providers/ProviderHelper.cs[8-15]
- src/Infrastructure/BotSharp.Core/Infrastructures/LlmProviderService.cs[77-95]
- src/Plugins/BotSharp.Plugin.OpenAI/Providers/Image/ImageCompletionProvider.Compose.cs[24-29]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
+29
to
32
| services.AddRefitClient<IMembaseApi>(new RefitSettings | ||
| { | ||
| CollectionFormat = CollectionFormat.Multi | ||
| }) |
Contributor
There was a problem hiding this comment.
2. Unpinned membase json deserialization 🐞 Bug ≡ Correctness
MembasePlugin no longer configures a specific Refit JSON content serializer, but graph construction relies on Dictionary<string, object?> values being JsonElement for node/edge objects. If Refit deserializes those object values into inferred CLR types (e.g., nested dictionaries) instead of JsonElement, GraphBuilder.Build will skip rows and can produce incomplete/empty graphs.
Agent Prompt
### Issue description
The Membase Refit client no longer pins JSON deserialization behavior. Downstream code expects `GraphQueryResult.Values` dictionaries to contain `JsonElement` objects for keys like `sourceNode`, `targetNode`, and `edge`.
### Issue Context
`MembaseGraphDb` passes `CypherQueryResponse.Data` straight through to `GraphQueryResult.Values`. `GraphBuilder.Build` uses `ObjectExtensions.TryGetValue<JsonElement>` and will `continue` (drop the row) when the value isn't a `JsonElement` (or already a `JsonElement`-deserializable `T`).
### Fix Focus Areas
- src/Plugins/BotSharp.Plugin.Membase/MembasePlugin.cs[21-39]
- src/Plugins/BotSharp.Plugin.Membase/GraphDb/MembaseGraphDb.cs[41-55]
- src/Infrastructure/BotSharp.Abstraction/Graph/Utils/GraphBuilder.cs[18-26]
- src/Infrastructure/BotSharp.Abstraction/Utilities/ObjectExtensions.cs[76-105]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1391