Skip to content

Fitting SASBDB auto-fill and CorMap support - #4079

Draft
wpotrzebowski wants to merge 2 commits into
sasbdb-corefrom
sasbdb-fitting
Draft

Fitting SASBDB auto-fill and CorMap support#4079
wpotrzebowski wants to merge 2 commits into
sasbdb-corefrom
sasbdb-fitting

Conversation

@wpotrzebowski

Copy link
Copy Markdown
Contributor

Summary

  • Split from draft PR SASBDB export #3912: Fitting getSASBDBData() auto-fill for SASBDB export, optional FreeSAS CorMap p-value, and related magnetism param-table fixes.
  • Depends on SASBDB export core library #4077 (sasbdb-core). Complements the dialog PR (sasbdb-dialog) but can merge independently after core.

Stack

Test plan

  • Fit a 1D dataset; open SASBDB export (with dialog PR) and confirm fields auto-populate
  • CorMap p-value present when FreeSAS installed; graceful skip otherwise
  • Fitting magnetism / core_shell_sphere tests still pass (FittingWidgetTest)

This was referenced Aug 4, 2026
@wpotrzebowski
wpotrzebowski marked this pull request as draft August 4, 2026 14:20
codescene-access[bot]

This comment was marked as outdated.

wpotrzebowski and others added 2 commits August 6, 2026 10:12
Expose getSASBDBData from Fitting so export can pre-populate from the
active fit tab, with optional FreeSAS CorMap and magnetism param sync.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

@codescene-access codescene-access Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our agent can fix these. Install it.

No quality gates enabled for this code.

Quality Gate Profile: Custom Configuration
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant