Skip to content

[autobackport: sssd-2-10] tests: remove multihost tests covered by system tests - #9068

Merged
spoore1 merged 6 commits into
SSSD:sssd-2-10from
sssd-bot:SSSD-sssd-backport-pr9042-to-sssd-2-10
Aug 11, 2026
Merged

[autobackport: sssd-2-10] tests: remove multihost tests covered by system tests#9068
spoore1 merged 6 commits into
SSSD:sssd-2-10from
sssd-bot:SSSD-sssd-backport-pr9042-to-sssd-2-10

Conversation

@sssd-bot

Copy link
Copy Markdown
Contributor

This is an automatic backport of PR#9042 tests: remove multihost tests covered by system tests to branch sssd-2-10, created by @danlavu.

Please make sure this backport is correct.

Note

The commits were cherry-picked without conflicts.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr9042-to-sssd-2-10
git checkout SSSD-sssd-backport-pr9042-to-sssd-2-10
git push sssd-bot SSSD-sssd-backport-pr9042-to-sssd-2-10 --force

Original commits
a9112d2 - tests: remove multihost/alltests/test_sudo.py
5cc2c3b - tests: remove multihost/alltests/test_sss_cache.py
bf174ca - tests: remove multihost/ad/test_sudo.py
c731a53 - tests: remove multihost/alltests/test_sssctl_analyzer.py
a074d5a - tests: remove multihost/alltests/test_autoprivategroup.py
d8be988 - tests: remove multihost/alltests/test_rfc2307.py

Backported commits

  • bf7e86a - tests: remove multihost/alltests/test_sudo.py
  • 9486309 - tests: remove multihost/alltests/test_sss_cache.py
  • 791b274 - tests: remove multihost/ad/test_sudo.py
  • dc7fd42 - tests: remove multihost/alltests/test_sssctl_analyzer.py
  • 7eb6086 - tests: remove multihost/alltests/test_autoprivategroup.py
  • 033a735 - tests: remove multihost/alltests/test_rfc2307.py

Original Pull Request Body

Remove 6 legacy multihost test files whose scenarios are fully covered by existing system tests.

Each commit removes one file and documents the exact system test function(s) that replaced it.

Files removed

File Cases Covered by
multihost/alltests/test_sudo.py 4 test_sudo.py
multihost/alltests/test_sss_cache.py 1 test_cache.py
multihost/ad/test_sudo.py 4 test_sudo.py
multihost/alltests/test_sssctl_analyzer.py 6 test_sssctl.py
multihost/alltests/test_autoprivategroup.py 2 test_identity.py
multihost/alltests/test_rfc2307.py 1 test_ldap.py

Total: 18 legacy cases removed, all covered by system tests.

Made with Cursor

@spoore1 spoore1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spoore1 spoore1 added Accepted Tests Trivial A single reviewer is sufficient to review the Pull Request no-backport This should go to target branch only. labels Aug 11, 2026
Dan Lavu added 6 commits August 11, 2026 12:16
All 4 cases are covered by system tests:
- test_bz1294670           -> test_sudo__duplicate_sudo_user
- test_timed_sudoers_entry -> test_sudo__sudonotbefore_shorttime
- test_randomize_sudo_timeout -> test_sudo__refresh_random_offset
- test_improve_refresh_timers_sudo_timeout -> test_sudo__prefer_full_refresh_over_smart_refresh

Co-authored-by: Cursor <cursoragent@cursor.com>

Generated-by: claude-sonnet-4-6
Reviewed-by: Scott Poore <spoore@redhat.com>
(cherry picked from commit a9112d2)
All 1 case is covered by system tests:
- test_sss_cache_reset -> test_cache__invalidate_entries_in_domain_and_timestamps_caches

Co-authored-by: Cursor <cursoragent@cursor.com>

Generated-by: claude-sonnet-4-6
Reviewed-by: Scott Poore <spoore@redhat.com>
(cherry picked from commit 5cc2c3b)
All 4 cases are covered by system tests:
- test_001_bz1380436                       -> test_sudo__user_is_group
- test_002_bz1372440                       -> test_sudo__runasuser_fqn
- test_003_support_non_posix_group_in_sudorule -> test_sudo__user_is_nonposix_group
- test_004_sudorule_with_short_username    -> test_sudo__runasuser_shortname

Co-authored-by: Cursor <cursoragent@cursor.com>

Generated-by: claude-sonnet-4-6
Reviewed-by: Scott Poore <spoore@redhat.com>
(cherry picked from commit bf174ca)
All 6 cases are covered by system tests (1:1 mapping):
- test_analyze_list            -> test_sssctl__analyze_list
- test_analyze_diff_log_location -> test_sssctl__analyze_non_default_log_location
- test_analyze_pam_logs        -> test_sssctl__analyze_pam_logs
- test_analyze_tevent_id       -> test_sssctl__analyze_tevent_id
- test_analyze_parse_child_logs -> test_sssctl__analyze_child_logs
- test_non_root_privileged     -> test_sssctl__analyze_without_root_privileges

Co-authored-by: Cursor <cursoragent@cursor.com>

Generated-by: claude-sonnet-4-6
Reviewed-by: Scott Poore <spoore@redhat.com>
(cherry picked from commit c731a53)
All 2 cases are covered by system tests:
- test_0001_bz1695577 (uid == gid, group exists) -> test_identity__lookup_when_auto_private_groups_is_set_to_hybrid
- test_0002_bz1695577 (uid != gid, group exists) -> test_identity__lookup_when_auto_private_groups_is_set_to_hybrid

Co-authored-by: Cursor <cursoragent@cursor.com>

Generated-by: claude-sonnet-4-6
Reviewed-by: Scott Poore <spoore@redhat.com>
(cherry picked from commit a074d5a)
All 1 case is covered by system tests:
- test_0001_bz1362023 (user with leading whitespace in userid) -> test_ldap__user_login_with_whitespace_prefix_in_userid

Co-authored-by: Cursor <cursoragent@cursor.com>

Generated-by: claude-sonnet-4-6
Reviewed-by: Scott Poore <spoore@redhat.com>
(cherry picked from commit d8be988)
@sssd-bot

Copy link
Copy Markdown
Contributor Author

The pull request was accepted by @spoore1 with the following PR CI status:


🟢 CodeQL (success)
🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 testing-farm:centos-stream-10-x86_64:upstream (success)
🟢 Build / make-distcheck (success)
🟢 ci / prepare (success)
🟢 ci / system (centos-10) (success)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot
sssd-bot force-pushed the SSSD-sssd-backport-pr9042-to-sssd-2-10 branch from 033a735 to 8842214 Compare August 11, 2026 12:16
@spoore1
spoore1 merged commit b3b2727 into SSSD:sssd-2-10 Aug 11, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted no-backport This should go to target branch only. Tests Trivial A single reviewer is sufficient to review the Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants