Fix bulk string operations with Oracle#1361
Merged
Merged
Conversation
Don't redeclare the same variables or do redeclare it but reduce the scope of a previously declared variable with the same name to avoid shadowing. No real changes. This commit is best viewed ignoring whitespace-only changes.
Use MSVS-specific localtime_s() instead when using this compiler.
This was broken by c35b1b6 (Avoid disabling MSVC CRT security warnings globally, 2025-06-08) which implicitly replaced std::strncpy() calls in Oracle vector use type backend with the calls to soci::strncpy() which doesn't behave in the same way as the standard function, e.g. it can't be used with n==0 and it always NUL-terminates the destination buffer. Restore the original strncpy() behaviour to fix this. See SOCI#1268.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.