fix: correct local styles path and improve setup resilience - #86
Open
nglmercer wants to merge 4 commits into
Open
fix: correct local styles path and improve setup resilience#86nglmercer wants to merge 4 commits into
nglmercer wants to merge 4 commits into
Conversation
Add `make doctor` / `cargo make doctor` to diagnose missing toolchains, submodules, and bundled assets. Fail fast with helpful errors when `extras`/`design-system-components` submodules or `bundled.css` are missing. Improve `cargo run` error message when `ssr` feature is not enabled.
Remove stale node_modules before reinstall, fix local styles path, and make postinstall skip gracefully when bundled.css is not built.
Added a comment to indicate route generation in Leptos App.
MarioYellowy
reviewed
Aug 8, 2026
MarioYellowy
left a comment
MarioYellowy
left a comment
Contributor
There was a problem hiding this comment.
Is not necessary at all, the main problem is the redundant use of task runners in the project, that explain why it works when you use only make commands, but fails with cargo make commands, unfortunately, in the last pull request was not updated the part of the dependencies that use, that explain why to the user @gg0074x marks a fails in the leptos dependencies, in addition, the project of design system components needs to be updated as well, when that project gets updated, the current problem here shouldn't be present, although some additions in the readme file look fine, but not all, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumen
@rustlanges/stylesenpackage.json(file:../design-system-components/styles→file:./design-system-components/styles), que impedía ejecutar el proyecto.setupahora limpianode_modulesantes de reinstalar para evitar estados inconsistentes.postinstallya no falla sibundled.cssno está construido; muestra un mensaje con el comando correcto.build:csspara reconstruir los estilos cuando sea necesario.Motivación
La ruta incorrecta del paquete de estilos rompía
cargo run/pnpm rundesde el primer momento. Este arreglo resuelve el problema de raíz y mejora los mensajes de error para futuras configuraciones.