cpufeatures: Enable compile time target features under Miri - #1513
Merged
Conversation
elichai
force-pushed
the
miri-cpufeatures
branch
from
August 5, 2026 13:59
ff2d41a to
e00363a
Compare
newpavlov
reviewed
Aug 10, 2026
elichai
force-pushed
the
miri-cpufeatures
branch
from
August 10, 2026 07:24
e00363a to
f8155d1
Compare
elichai
force-pushed
the
miri-cpufeatures
branch
from
August 10, 2026 07:26
f8155d1 to
56ce971
Compare
newpavlov
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Miri already supports a lot of intrinsics: https://github.com/rust-lang/miri/tree/master/src/intrinsics so I think it make sense to return
truefor compile time enabled features, so if someone runsRUSTFLAGS=+avx2 cargo miri runit will actually enable those features, as the user explicitly asked for themAlso added tests to show that it works outside and inside of miri
tested everything locally too(including loongarch64 via qemu)